[PATCH] fix /proc/asound/card*/via82xx formatting

[PATCH] fix /proc/asound/card*/via82xx formatting

[Sergey Vlasov]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

Hello!

In ALSA 1.0.0rc1 the data in /proc/asound/card*/via82xx seems to be
formatted badly (missing '\n', so all register values end up in a
single line):

==========================
VIA 8235 at 0xe000, irq 22

00: 0000238004: 032bc06c08: ff3fffff0c: 0d00089810: 3f00000014: 0000000018: ff0fffff1c: 0000000020: 3f00000024: 0000000028: ff0fffff2c: 0000000030: 3f00000034: 0000000038: ff0fffff3c: 0000000040: 0000000044: 0000000048: ff0000004c: 0000000050: 0000000054: 0000000058: f42415d45c: 0000000060: 0000000064: 0000000068: ff0000006c: 0000000070: 0000000074: 0000000078: ff0000007c: 0000000080: 022cbb8084: 0000000888: 000000008c: 0000000090: 0000cc0194: 0000000098: 000000009c: 00000000
==========================

This trivial patch fixes the problem:

--- alsa-driver-1.0.0rc1/alsa-kernel/pci/via82xx.c.via82xx-proc	2003-12-03 10:53:31 +0300
+++ alsa-driver-1.0.0rc1/alsa-kernel/pci/via82xx.c	2003-12-03 11:25:07 +0300
@@ -1711,7 +1711,7 @@
 	
 	snd_iprintf(buffer, "%s\n\n", chip->card->longname);
 	for (i = 0; i < 0xa0; i += 4) {
-		snd_iprintf(buffer, "%02x: %08x", i, inl(chip->port + i));
+		snd_iprintf(buffer, "%02x: %08x\n", i, inl(chip->port + i));
 	}
 }
 

-- 
Sergey Vlasov

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] fix /proc/asound/card*/via82xx formatting

[Takashi Iwai]

At Wed, 3 Dec 2003 11:35:31 +0300,
Sergey Vlasov wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> Hello!
> 
> In ALSA 1.0.0rc1 the data in /proc/asound/card*/via82xx seems to be
> formatted badly (missing '\n', so all register values end up in a
> single line):
> 
> ==========================
> VIA 8235 at 0xe000, irq 22
> 
> 00: 0000238004: 032bc06c08: ff3fffff0c: 0d00089810: 3f00000014: 0000000018: ff0fffff1c: 0000000020: 3f00000024: 0000000028: ff0fffff2c: 0000000030: 3f00000034: 0000000038: ff0fffff3c: 0000000040: 0000000044: 0000000048: ff0000004c: 0000000050: 0000000054: 0000000058: f42415d45c: 0000000060: 0000000064: 0000000068: ff0000006c: 0000000070: 0000000074: 0000000078: ff0000007c: 0000000080: 022cbb8084: 0000000888: 000000008c: 0000000090: 0000cc0194: 0000000098: 000000009c: 00000000
> ==========================
> 
> This trivial patch fixes the problem:

thanks, applied now.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/