[PATCH] Re: [Alsa-user] Hercules Gametheater XP (cs46xx)

[PATCH] Re: [Alsa-user] Hercules Gametheater XP (cs46xx)

[Benny Sjöstrand]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

> Sorry, but latest CVS does not work. Sound is still very distorted. 
> CVS from 2002-12-09 12:00 works well though, which is what I'm using 
> now :) It is using version 1.37 alsa-kernel/pci/cs46xx/cs46xx_lib.cc.

Current CVS still seems to be broken. The hercules_init(...) function 
will reset the EGPIO's to default state  turning of the amplifier. This 
patch changes the initialization order calling amplifier_ctrl(...) after 
mixer_init.

/Benny

[-- Attachment #2: cs46xx.patch --]
[-- Type: text/plain, Size: 554 bytes --]

--- cs46xx_lib.c.orig	2003-02-16 15:28:21.000000000 +0100
+++ cs46xx_lib.c	2003-02-16 15:28:34.000000000 +0100
@@ -2516,9 +2516,6 @@
 	strcpy(id.name, "External Amplifier Power Down");
 	chip->eapd_switch = snd_ctl_find_id(chip->card, &id);
     
-	/* turn on amplifier */
-	chip->amplifier_ctrl(chip, 1);
-
 #ifdef CONFIG_SND_CS46XX_NEW_DSP
 	/* do soundcard specific mixer setup */
 	if (chip->mixer_init) {
@@ -2526,6 +2523,9 @@
 		chip->mixer_init(chip);
 	}
 #endif
+
+ 	/* turn on amplifier */
+	chip->amplifier_ctrl(chip, 1);
     
 	return 0;
 }

Re: [PATCH] Re: [Alsa-user] Hercules Gametheater XP (cs46xx)

[Takashi Iwai]

At Sun, 16 Feb 2003 15:33:38 +0100,
Benny Sjöstrand wrote:
> 
> > Sorry, but latest CVS does not work. Sound is still very distorted. 
> > CVS from 2002-12-09 12:00 works well though, which is what I'm using 
> > now :) It is using version 1.37 alsa-kernel/pci/cs46xx/cs46xx_lib.cc.
> 
> Current CVS still seems to be broken. The hercules_init(...) function 
> will reset the EGPIO's to default state  turning of the amplifier. This 
> patch changes the initialization order calling amplifier_ctrl(...) after 
> mixer_init.

thanks, applied to cvs.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: [PATCH] Re: [Alsa-user] Hercules Gametheater XP (cs46xx)

[Christian Esken]

Am Monday 17 February 2003 11:15 schrieb Takashi Iwai:
> At Sun, 16 Feb 2003 15:33:38 +0100,
>
> Benny Sjöstrand wrote:
> > > Sorry, but latest CVS does not work. Sound is still very distorted.
> > > CVS from 2002-12-09 12:00 works well though, which is what I'm using
> > > now :) It is using version 1.37 alsa-kernel/pci/cs46xx/cs46xx_lib.cc.
> >
> > Current CVS still seems to be broken. The hercules_init(...) function
> > will reset the EGPIO's to default state  turning of the amplifier. This
> > patch changes the initialization order calling amplifier_ctrl(...) after
> > mixer_init.
>
> thanks, applied to cvs.

Confirmed - it works on my Hercules GT XP !!! Yippey. :-)))))
This ultimately fixes the "distortion problem" that has been there for
me (and others) all the time since after 0.9.0rc2.

A very very very big thanks from me too, Benny. You have made me
very happy today. This calls for a drink. :-)

Best regards,
          Christian



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf