All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@suse.cz>
Subject: Re: [PATCH] sound: fix incorrect use of	platform_device_register()
Date: Mon, 23 Apr 2007 11:55:23 +0200	[thread overview]
Message-ID: <s5hmz0zv2ic.wl%tiwai@suse.de> (raw)
In-Reply-To: <20070421072339.GA3699@APFDCB5C>

At Sat, 21 Apr 2007 16:23:39 +0900,
Akinobu Mita wrote:
> 
> The platform_device allocated by platform_device_alloc()
> should be added to the device hierarchy by platform_device_add()
> instead of platform_device_register().
> 
> Otherwise it will hit WARN_ON() in platform_device_register().
> by illegal refcount.
> 
> This patch fixes such incorrect usages in portman2x4 and mts64 drivers.
> Also it removes unnecessary trailing whitespaces.
> 
> Cc: Jaroslav Kysela <perex@suse.cz>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

Thanks, applied to ALSA tree now.


Takashi

      reply	other threads:[~2007-04-23  9:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-21  7:23 [PATCH] sound: fix incorrect use of platform_device_register() Akinobu Mita
2007-04-23  9:55 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmz0zv2ic.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=akinobu.mita@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.