Re: [PATCH 30/39] sound/vx_core: replace schedule_timeout() with msleep()

[Takashi Iwai <tiwai@suse.de>]

At Fri, 21 Jan 2005 11:47:31 -0800,
Nishanth Aravamudan wrote:
> 
> Hi,
> 
> Please consider applying.
> 
> Description: Use msleep() instead of schedule_timeout() to guarantee the task
> delays as expected. The check for xmsec >= 1000 / HZ seems wrong to me, as well,
> since if HZ==100, that means we could mdelay() for 9 msecs!

Yes, and that's intentional.  Originally there were places to call
like snd_vx_delay(1) for just 1 or 2 ms in a long loop.  The loop
calls schedule() occasionally to take control back.
So, we didn't want to do schedule_timeout(1) for HZ=100 in such a
case.  This results in 10 times longer loop execution.

>  msleep() should be
> usable in all cases when not in an interrupt handler.

I agree in general, but, msleep() isn't always a replacement of
mdelay() if the delay time really matters.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl