From: Takashi Iwai <tiwai@suse.de>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Adrian Bunk <bunk@stusta.de>,
perex@suse.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: Re: [2.6 patch] ALSA: misc cleanups
Date: Mon, 06 Dec 2004 20:41:35 +0100 [thread overview]
Message-ID: <s5hmzwrb4eo.wl@alsa2.suse.de> (raw)
In-Reply-To: <1102358650.2897.6.camel@krustophenia.net>
At Mon, 06 Dec 2004 13:44:10 -0500,
Lee Revell wrote:
>
> On Mon, 2004-12-06 at 01:12 +0100, Adrian Bunk wrote:
> > - sound/synth/emux/emux_synth.c: snd_emux_release_voice
>
> Hmm, this should be used. I will check it out.
It's ok. It's neither used nor exported.
Looks like an obsolete function.
> > - sound/synth/emux/soundfont.: snd_soundfont_mem_used
>
> This one should be used also.
It should be ok, too. It's a one-line accessor, so the driver can
read the value directly from the struct instead.
Takashi
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Adrian Bunk <bunk@stusta.de>,
perex@suse.cz, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [Alsa-devel] Re: [2.6 patch] ALSA: misc cleanups
Date: Mon, 06 Dec 2004 20:41:35 +0100 [thread overview]
Message-ID: <s5hmzwrb4eo.wl@alsa2.suse.de> (raw)
In-Reply-To: <1102358650.2897.6.camel@krustophenia.net>
At Mon, 06 Dec 2004 13:44:10 -0500,
Lee Revell wrote:
>
> On Mon, 2004-12-06 at 01:12 +0100, Adrian Bunk wrote:
> > - sound/synth/emux/emux_synth.c: snd_emux_release_voice
>
> Hmm, this should be used. I will check it out.
It's ok. It's neither used nor exported.
Looks like an obsolete function.
> > - sound/synth/emux/soundfont.: snd_soundfont_mem_used
>
> This one should be used also.
It should be ok, too. It's a one-line accessor, so the driver can
read the value directly from the struct instead.
Takashi
next prev parent reply other threads:[~2004-12-06 19:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-06 0:12 [2.6 patch] ALSA: misc cleanups Adrian Bunk
2004-12-06 18:44 ` Lee Revell
2004-12-06 18:44 ` Lee Revell
2004-12-06 19:41 ` Takashi Iwai [this message]
2004-12-06 19:41 ` [Alsa-devel] " Takashi Iwai
2004-12-07 15:36 ` Takashi Iwai
2004-12-07 15:36 ` [Alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmzwrb4eo.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=rlrevell@joe-job.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.