* [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion NT950XCJ-X716A
@ 2020-08-26 8:40 ` Adrien Crivelli
0 siblings, 0 replies; 5+ messages in thread
From: Adrien Crivelli @ 2020-08-26 8:40 UTC (permalink / raw)
Cc: linux-kernel, alsa-devel, Takashi Iwai, Adrien Crivelli
The Galaxy Book Ion NT950XCJ-X716A (15 inches) uses the same ALC298
codec as other Samsung laptops which have the no headphone sound bug. I
confirmed on my own hardware that this fixes the bug.
This also correct the model name for the 13 inches version. It was
incorrectly referenced as NT950XCJ-X716A in commit e17f02d05. But it
should have been NP930XCJ-K01US.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207423
Signed-off-by: Adrien Crivelli <adrien.crivelli@gmail.com>
---
sound/pci/hda/patch_realtek.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a1fa983d2..98789691a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7695,7 +7695,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
SND_PCI_QUIRK(0x144d, 0xc189, "Samsung Galaxy Flex Book (NT950QCG-X716)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
- SND_PCI_QUIRK(0x144d, 0xc18a, "Samsung Galaxy Book Ion (NT950XCJ-X716A)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
+ SND_PCI_QUIRK(0x144d, 0xc18a, "Samsung Galaxy Book Ion (NP930XCJ-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
+ SND_PCI_QUIRK(0x144d, 0xc830, "Samsung Galaxy Book Ion (NT950XCJ-X716A)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8),
SND_PCI_QUIRK(0x144d, 0xc812, "Samsung Notebook Pen S (NT950SBE-X58)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC),
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion NT950XCJ-X716A
@ 2020-08-26 8:40 ` Adrien Crivelli
0 siblings, 0 replies; 5+ messages in thread
From: Adrien Crivelli @ 2020-08-26 8:40 UTC (permalink / raw)
Cc: Adrien Crivelli, Jaroslav Kysela, Takashi Iwai, alsa-devel,
linux-kernel
The Galaxy Book Ion NT950XCJ-X716A (15 inches) uses the same ALC298
codec as other Samsung laptops which have the no headphone sound bug. I
confirmed on my own hardware that this fixes the bug.
This also correct the model name for the 13 inches version. It was
incorrectly referenced as NT950XCJ-X716A in commit e17f02d05. But it
should have been NP930XCJ-K01US.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207423
Signed-off-by: Adrien Crivelli <adrien.crivelli@gmail.com>
---
sound/pci/hda/patch_realtek.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index a1fa983d2..98789691a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7695,7 +7695,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x144d, 0xc169, "Samsung Notebook 9 Pen (NP930SBE-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
SND_PCI_QUIRK(0x144d, 0xc176, "Samsung Notebook 9 Pro (NP930MBE-K04US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
SND_PCI_QUIRK(0x144d, 0xc189, "Samsung Galaxy Flex Book (NT950QCG-X716)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
- SND_PCI_QUIRK(0x144d, 0xc18a, "Samsung Galaxy Book Ion (NT950XCJ-X716A)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
+ SND_PCI_QUIRK(0x144d, 0xc18a, "Samsung Galaxy Book Ion (NP930XCJ-K01US)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
+ SND_PCI_QUIRK(0x144d, 0xc830, "Samsung Galaxy Book Ion (NT950XCJ-X716A)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
SND_PCI_QUIRK(0x144d, 0xc740, "Samsung Ativ book 8 (NP870Z5G)", ALC269_FIXUP_ATIV_BOOK_8),
SND_PCI_QUIRK(0x144d, 0xc812, "Samsung Notebook Pen S (NT950SBE-X58)", ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET),
SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC),
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion NT950XCJ-X716A
2020-08-26 8:40 ` Adrien Crivelli
@ 2020-08-26 8:47 ` Takashi Iwai
-1 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2020-08-26 8:47 UTC (permalink / raw)
To: Adrien Crivelli; +Cc: linux-kernel, alsa-devel, Takashi Iwai
On Wed, 26 Aug 2020 10:40:14 +0200,
Adrien Crivelli wrote:
>
> The Galaxy Book Ion NT950XCJ-X716A (15 inches) uses the same ALC298
> codec as other Samsung laptops which have the no headphone sound bug. I
> confirmed on my own hardware that this fixes the bug.
>
> This also correct the model name for the 13 inches version. It was
> incorrectly referenced as NT950XCJ-X716A in commit e17f02d05. But it
> should have been NP930XCJ-K01US.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207423
> Signed-off-by: Adrien Crivelli <adrien.crivelli@gmail.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion NT950XCJ-X716A
@ 2020-08-26 8:47 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2020-08-26 8:47 UTC (permalink / raw)
To: Adrien Crivelli; +Cc: Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
On Wed, 26 Aug 2020 10:40:14 +0200,
Adrien Crivelli wrote:
>
> The Galaxy Book Ion NT950XCJ-X716A (15 inches) uses the same ALC298
> codec as other Samsung laptops which have the no headphone sound bug. I
> confirmed on my own hardware that this fixes the bug.
>
> This also correct the model name for the 13 inches version. It was
> incorrectly referenced as NT950XCJ-X716A in commit e17f02d05. But it
> should have been NP930XCJ-K01US.
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207423
> Signed-off-by: Adrien Crivelli <adrien.crivelli@gmail.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion NT950XCJ-X716A
2020-08-26 8:47 ` Takashi Iwai
(?)
@ 2020-08-26 8:48 ` Adrien Crivelli
-1 siblings, 0 replies; 5+ messages in thread
From: Adrien Crivelli @ 2020-08-26 8:48 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-kernel, alsa-devel, Takashi Iwai
Great, thanks!
On Wed, 26 Aug 2020 at 17:47, Takashi Iwai <tiwai@suse.de> wrote:
> On Wed, 26 Aug 2020 10:40:14 +0200,
> Adrien Crivelli wrote:
> >
> > The Galaxy Book Ion NT950XCJ-X716A (15 inches) uses the same ALC298
> > codec as other Samsung laptops which have the no headphone sound bug. I
> > confirmed on my own hardware that this fixes the bug.
> >
> > This also correct the model name for the 13 inches version. It was
> > incorrectly referenced as NT950XCJ-X716A in commit e17f02d05. But it
> > should have been NP930XCJ-K01US.
> >
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207423
> > Signed-off-by: Adrien Crivelli <adrien.crivelli@gmail.com>
>
> Thanks, applied.
>
>
> Takashi
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-26 8:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-26 8:40 [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion NT950XCJ-X716A Adrien Crivelli
2020-08-26 8:40 ` Adrien Crivelli
2020-08-26 8:47 ` Takashi Iwai
2020-08-26 8:47 ` Takashi Iwai
2020-08-26 8:48 ` Adrien Crivelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.