All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org,
	Quentin Lambert <lambert.quentin@gmail.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [patch] ALSA: mixart: silence an uninitialized	variable warning
Date: Wed, 16 Mar 2016 16:35:33 +0100	[thread overview]
Message-ID: <s5hoaaebflm.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160316074213.GC12860@mwanda>

On Wed, 16 Mar 2016 08:42:13 +0100,
Dan Carpenter wrote:
> 
> We could print the uninitialized value of "stat" in the error message.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.


Takashi

> 
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
>  	}
>  
>  	if(start) {
> -		u32 stat;
> +		u32 stat = 0;
>  
>  		group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>  
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: alsa-devel@alsa-project.org,
	Quentin Lambert <lambert.quentin@gmail.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [alsa-devel] [patch] ALSA: mixart: silence an uninitialized	variable warning
Date: Wed, 16 Mar 2016 15:35:33 +0000	[thread overview]
Message-ID: <s5hoaaebflm.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160316074213.GC12860@mwanda>

On Wed, 16 Mar 2016 08:42:13 +0100,
Dan Carpenter wrote:
> 
> We could print the uninitialized value of "stat" in the error message.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.


Takashi

> 
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
>  	}
>  
>  	if(start) {
> -		u32 stat;
> +		u32 stat = 0;
>  
>  		group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>  
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org,
	Quentin Lambert <lambert.quentin@gmail.com>,
	kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [patch] ALSA: mixart: silence an uninitialized	variable warning
Date: Wed, 16 Mar 2016 16:35:33 +0100	[thread overview]
Message-ID: <s5hoaaebflm.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160316074213.GC12860@mwanda>

On Wed, 16 Mar 2016 08:42:13 +0100,
Dan Carpenter wrote:
> 
> We could print the uninitialized value of "stat" in the error message.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.


Takashi

> 
> diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c
> index bc81b9f..25c0ddd 100644
> --- a/sound/pci/mixart/mixart.c
> +++ b/sound/pci/mixart/mixart.c
> @@ -132,7 +132,7 @@ static int mixart_set_pipe_state(struct mixart_mgr *mgr,
>  	}
>  
>  	if(start) {
> -		u32 stat;
> +		u32 stat = 0;
>  
>  		group_state.pipe_count = 0; /* in case of start same command once again with pipe_count=0 */
>  
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  parent reply	other threads:[~2016-03-16 15:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16  7:42 [patch] ALSA: mixart: silence an uninitialized variable warning Dan Carpenter
2016-03-16  7:42 ` Dan Carpenter
2016-03-16  8:22 ` walter harms
2016-03-16  8:22   ` walter harms
2016-03-16 15:35 ` Takashi Iwai [this message]
2016-03-16 15:35   ` [alsa-devel] " Takashi Iwai
2016-03-16 15:35   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hoaaebflm.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lambert.quentin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.