All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de
Subject: Re: [PATCH v2] control: complement comment for subscribe API
Date: Mon, 09 Feb 2015 16:35:50 +0100	[thread overview]
Message-ID: <s5hoap3rtbd.wl-tiwai@suse.de> (raw)
In-Reply-To: <1423495639-25249-1-git-send-email-o-takashi@sakamocchi.jp>

At Tue, 10 Feb 2015 00:27:19 +0900,
Takashi Sakamoto wrote:
> 
> When minus value is given as a parameter, the API returns whether
> the caller has already subscribed or not.
> 
> This commit adds a comment about this so as better documentation.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Applied, thanks.


Takashi

> ---
>  src/control/control.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/control/control.c b/src/control/control.c
> index dd428a1..4a28cf6 100644
> --- a/src/control/control.c
> +++ b/src/control/control.c
> @@ -213,7 +213,7 @@ int snd_ctl_poll_descriptors_revents(snd_ctl_t *ctl, struct pollfd *pfds, unsign
>  /**
>   * \brief Ask to be informed about events (poll, #snd_async_add_ctl_handler, #snd_ctl_read)
>   * \param ctl CTL handle
> - * \param subscribe 0 = unsubscribe, 1 = subscribe
> + * \param subscribe 0 = unsubscribe, 1 = subscribe, -1 = check subscribe or not
>   * \return 0 on success otherwise a negative error code
>   */
>  int snd_ctl_subscribe_events(snd_ctl_t *ctl, int subscribe)
> -- 
> 2.1.0
> 

      reply	other threads:[~2015-02-09 15:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 15:18 [PATCH lib] control: complement comment for subscribe API Takashi Sakamoto
2015-02-09 15:22 ` Takashi Sakamoto
2015-02-09 15:27 ` [PATCH v2] " Takashi Sakamoto
2015-02-09 15:35   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hoap3rtbd.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=o-takashi@sakamocchi.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.