RE: Show currectly selected widget in proc_read for hda driver

RE: Show currectly selected widget in proc_read for hda driver

["Tien, C.L. - 田承禮"]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]


Execuse me, this one is a better implement. I don't issue the GET_CONNECT for list length is 1, which is not necessary and can cause problem.

Please ignore previous patch.

Sincerely,
ChenLi Tien

-----Original Message-----
From:	Tien,  C.L. - 田承禮
Sent:	2005/3/24 [星期四] 上午 12:17
To:	alsa-devel@alsa-project.org
Cc:	
Subject:	Show currectly selected widget in proc_read for hda driver

Summary: <Show currectly selected widget in proc_read for hda driver>
Signed-off-by: ChenLi Tien<cltien@cmedia.com.tw>

Durind debugging for cm9880 multi-channel playback, I added the * after the currently selected widget, mixer widget doesn't need this but other 3 widget types  need it.

Sincerely,
ChenLi Tien




[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: hda_proc.c.patch --]
[-- Type: text/x-patch; name="hda_proc.c.patch", Size: 1056 bytes --]

Index: alsa-cvs/alsa-kernel/pci/hda/hda_proc.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/hda/hda_proc.c,v
retrieving revision 1.1
diff -a -u -r1.1 hda_proc.c
--- alsa-cvs/alsa-kernel/pci/hda/hda_proc.c	20 Jan 2005 15:02:28 -0000	1.1
+++ alsa-cvs/alsa-kernel/pci/hda/hda_proc.c	24 Mar 2005 05:20:57 -0000
@@ -266,13 +266,19 @@
 
 		if (wid_caps & AC_WCAP_CONN_LIST) {
 			hda_nid_t conn[HDA_MAX_CONNECTIONS];
-			int c, conn_len;
+			int c, conn_len, curr = -1;
 			conn_len = snd_hda_get_connections(codec, nid, conn,
 							   HDA_MAX_CONNECTIONS);
+			if (conn_len > 1 && wid_type != AC_WID_AUD_MIX)
+				curr = snd_hda_codec_read(codec, nid, 0,
+					AC_VERB_GET_CONNECT_SEL, 0);
 			snd_iprintf(buffer, "  Connection: %d\n", conn_len);
 			snd_iprintf(buffer, "    ");
-			for (c = 0; c < conn_len; c++)
+			for (c = 0; c < conn_len; c++) {
 				snd_iprintf(buffer, " 0x%02x", conn[c]);
+				if (c == curr)
+					snd_iprintf(buffer, "*");
+			}
 			snd_iprintf(buffer, "\n");
 		}
 	}

Re: RE: Show currectly selected widget in proc_read for hda driver

[Takashi Iwai]

At Thu, 24 Mar 2005 13:29:54 +0800,
Tien, C.L. wrote:
> 
> Execuse me, this one is a better implement. I don't issue the GET_CONNECT for list length is 1, which is not necessary and can cause problem.
> 
> Please ignore previous patch.
> 
> Sincerely,
> ChenLi Tien
> 
> -----Original Message-----
> From:	Tien,  C.L. - 田承禮
> Sent:	2005/3/24 [星期四] 上午 12:17
> To:	alsa-devel@alsa-project.org
> Cc:	
> Subject:	Show currectly selected widget in proc_read for hda driver
> 
> Summary: <Show currectly selected widget in proc_read for hda driver>
> Signed-off-by: ChenLi Tien<cltien@cmedia.com.tw>
> 
> Durind debugging for cm9880 multi-channel playback, I added the * after the currently selected widget, mixer widget doesn't need this but other 3 widget types  need it.
> 
> Sincerely,
> ChenLi Tien

Thanks for the patch.  It's a neat feature.
Applied to CVS now.  (but might be too late for rc2.)


Takashi


-------------------------------------------------------
This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005
Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows
Embedded(r) & Windows Mobile(tm) platforms, applications & content.  Register
by 3/29 & save $300 http://ads.osdn.com/?ad_idh83&alloc_id\x15149&op=click