* [PATCH 7/8] Kconfig: cleanup sound menu
@ 2005-01-29 22:20 Roman Zippel
2005-01-31 13:29 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Roman Zippel @ 2005-01-29 22:20 UTC (permalink / raw)
To: Andrew Morton, linux-kernel
This properly indents the sound menu.
Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
---
core/Kconfig | 7 ++++++-
oss/Kconfig | 8 ++++----
2 files changed, 10 insertions(+), 5 deletions(-)
Index: linux-2.6.11/sound/oss/Kconfig
===================================================================
--- linux-2.6.11.orig/sound/oss/Kconfig 2005-01-29 22:56:42.549085439 +0100
+++ linux-2.6.11/sound/oss/Kconfig 2005-01-29 22:56:50.842656776 +0100
@@ -880,6 +880,10 @@ config SOUND_SB
You can say M here to compile this driver as a module; the module is
called sb.
+config SOUND_KAHLUA
+ tristate "XpressAudio Sound Blaster emulation"
+ depends on SOUND_SB
+
config SOUND_AWE32_SYNTH
tristate "AWE32 synth"
depends on SOUND_OSS
@@ -1104,10 +1108,6 @@ config SOUND_TVMIXER
Support for audio mixer facilities on the BT848 TV frame-grabber
card.
-config SOUND_KAHLUA
- tristate "XpressAudio Sound Blaster emulation"
- depends on SOUND_SB
-
config SOUND_ALI5455
tristate "ALi5455 audio support"
depends on SOUND_PRIME!=n && PCI
Index: linux-2.6.11/sound/core/Kconfig
===================================================================
--- linux-2.6.11.orig/sound/core/Kconfig 2005-01-29 22:50:43.345956362 +0100
+++ linux-2.6.11/sound/core/Kconfig 2005-01-29 22:56:50.843656604 +0100
@@ -1,16 +1,20 @@
# ALSA soundcard-configuration
config SND_TIMER
tristate
+ depends on SND
config SND_PCM
tristate
select SND_TIMER
+ depends on SND
config SND_HWDEP
tristate
+ depends on SND
config SND_RAWMIDI
tristate
+ depends on SND
config SND_SEQUENCER
tristate "Sequencer support"
@@ -40,6 +44,7 @@ config SND_SEQ_DUMMY
config SND_OSSEMUL
bool
+ depends on SND
config SND_MIXER_OSS
tristate "OSS Mixer API"
@@ -70,7 +75,7 @@ config SND_PCM_OSS
config SND_SEQUENCER_OSS
bool "OSS Sequencer API"
- depends on SND_SEQUENCER
+ depends on SND && SND_SEQUENCER
select SND_OSSEMUL
help
Say Y here to enable OSS sequencer emulation (both
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 7/8] Kconfig: cleanup sound menu
2005-01-29 22:20 [PATCH 7/8] Kconfig: cleanup sound menu Roman Zippel
@ 2005-01-31 13:29 ` Takashi Iwai
2005-01-31 13:59 ` Roman Zippel
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2005-01-31 13:29 UTC (permalink / raw)
To: Roman Zippel; +Cc: Andrew Morton, linux-kernel
At Sat, 29 Jan 2005 23:20:48 +0100 (CET),
Roman Zippel wrote:
>
> Index: linux-2.6.11/sound/core/Kconfig
> ===================================================================
> --- linux-2.6.11.orig/sound/core/Kconfig 2005-01-29 22:50:43.345956362 +0100
> +++ linux-2.6.11/sound/core/Kconfig 2005-01-29 22:56:50.843656604 +0100
> @@ -1,16 +1,20 @@
> # ALSA soundcard-configuration
> config SND_TIMER
> tristate
> + depends on SND
(snip)
Aren't they superfluous?
SND_TIMER, etc, are the reverse selection entries.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 7/8] Kconfig: cleanup sound menu
2005-01-31 13:29 ` Takashi Iwai
@ 2005-01-31 13:59 ` Roman Zippel
2005-01-31 17:34 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Roman Zippel @ 2005-01-31 13:59 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Andrew Morton, linux-kernel
Hi,
On Mon, 31 Jan 2005, Takashi Iwai wrote:
> > Index: linux-2.6.11/sound/core/Kconfig
> > ===================================================================
> > --- linux-2.6.11.orig/sound/core/Kconfig 2005-01-29 22:50:43.345956362 +0100
> > +++ linux-2.6.11/sound/core/Kconfig 2005-01-29 22:56:50.843656604 +0100
> > @@ -1,16 +1,20 @@
> > # ALSA soundcard-configuration
> > config SND_TIMER
> > tristate
> > + depends on SND
> (snip)
>
> Aren't they superfluous?
> SND_TIMER, etc, are the reverse selection entries.
Without it they break the menu structure.
bye, Roman
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 7/8] Kconfig: cleanup sound menu
2005-01-31 13:59 ` Roman Zippel
@ 2005-01-31 17:34 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2005-01-31 17:34 UTC (permalink / raw)
To: Roman Zippel; +Cc: Andrew Morton, linux-kernel
At Mon, 31 Jan 2005 14:59:12 +0100 (CET),
Roman Zippel wrote:
>
> Hi,
>
> On Mon, 31 Jan 2005, Takashi Iwai wrote:
>
> > > Index: linux-2.6.11/sound/core/Kconfig
> > > ===================================================================
> > > --- linux-2.6.11.orig/sound/core/Kconfig 2005-01-29 22:50:43.345956362 +0100
> > > +++ linux-2.6.11/sound/core/Kconfig 2005-01-29 22:56:50.843656604 +0100
> > > @@ -1,16 +1,20 @@
> > > # ALSA soundcard-configuration
> > > config SND_TIMER
> > > tristate
> > > + depends on SND
> > (snip)
> >
> > Aren't they superfluous?
> > SND_TIMER, etc, are the reverse selection entries.
>
> Without it they break the menu structure.
OK, I applied it to ALSA tree, too.
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-01-31 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-29 22:20 [PATCH 7/8] Kconfig: cleanup sound menu Roman Zippel
2005-01-31 13:29 ` Takashi Iwai
2005-01-31 13:59 ` Roman Zippel
2005-01-31 17:34 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.