All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 1/2] gus_wave.c - vfree() checking cleanups
@ 2005-01-10 18:36 domen
  2005-01-11 10:26 ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: domen @ 2005-01-10 18:36 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel, domen, jlamanna



gus_wave.c vfree() checking cleanups.

Signed-off by: James Lamanna <jlamanna@gmail.com>


Signed-off-by: Domen Puncer <domen@coderock.org>
---


 kj-domen/sound/oss/gus_wave.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN sound/oss/gus_wave.c~vfree-sound_oss_gus_wave sound/oss/gus_wave.c
--- kj/sound/oss/gus_wave.c~vfree-sound_oss_gus_wave	2005-01-10 18:01:07.000000000 +0100
+++ kj-domen/sound/oss/gus_wave.c	2005-01-10 18:01:07.000000000 +0100
@@ -3126,8 +3126,7 @@ void __exit gus_wave_unload(struct addre
 	if (hw_config->slots[5] != -1)
 		sound_unload_mixerdev(hw_config->slots[5]);
 	
-	if(samples)
-		vfree(samples);
+	vfree(samples);
 	samples=NULL;
 }
 /* called in interrupt context */
_


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 1/2] gus_wave.c - vfree() checking cleanups
  2005-01-10 18:36 [patch 1/2] gus_wave.c - vfree() checking cleanups domen
@ 2005-01-11 10:26 ` Takashi Iwai
  2005-01-11 11:18   ` Domen Puncer
  0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2005-01-11 10:26 UTC (permalink / raw)
  To: domen; +Cc: perex, alsa-devel, jlamanna

At Mon, 10 Jan 2005 19:36:35 +0100,
domen@coderock.org wrote:
> 
> gus_wave.c vfree() checking cleanups.

I think Jaroslav isn't responsible for OSS stuff.
Could you repost it LKML rather than ALSA ML?


Takashi


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch 1/2] gus_wave.c - vfree() checking cleanups
  2005-01-11 10:26 ` Takashi Iwai
@ 2005-01-11 11:18   ` Domen Puncer
  0 siblings, 0 replies; 3+ messages in thread
From: Domen Puncer @ 2005-01-11 11:18 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: perex, alsa-devel, jlamanna

On 11/01/05 11:26 +0100, Takashi Iwai wrote:
> At Mon, 10 Jan 2005 19:36:35 +0100,
> domen@coderock.org wrote:
> > 
> > gus_wave.c vfree() checking cleanups.
> 
> I think Jaroslav isn't responsible for OSS stuff.
> Could you repost it LKML rather than ALSA ML?

In maintainers, he's listed under SOUND, and that deceived me.
Will report to lkml later.

Thanks.

> 
> 
> Takashi


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-01-11 11:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-10 18:36 [patch 1/2] gus_wave.c - vfree() checking cleanups domen
2005-01-11 10:26 ` Takashi Iwai
2005-01-11 11:18   ` Domen Puncer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.