serialmidi change breaks build on 2.6.10-rc2-mm2

serialmidi change breaks build on 2.6.10-rc2-mm2

[Lee Revell]

Rather than fixing anything this change actually broke compilation on my
kernel.  Is this change only in the latest rc or Linus' BK tree?

+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 10)
+                       count = driver->write(tty, buf, count);
+#else
                        count = driver->write(tty, 0, buf, count);
+#endif
                        snd_rawmidi_transmit_ack(serial->substream_output, count);
                } else {
                        clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags);


-- 
Lee Revell <rlrevell@joe-job.com>



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: serialmidi change breaks build on 2.6.10-rc2-mm2

[Takashi Iwai]

At Tue, 23 Nov 2004 18:31:02 -0500,
Lee Revell wrote:
> 
> Rather than fixing anything this change actually broke compilation on my
> kernel.  Is this change only in the latest rc or Linus' BK tree?

The patch is needed for Linus 2.6.10-rc2.
I checked 2.6.10-rc2-mm3 now, but it doesn't contain any change to
tty_driver.*.  Could you recheck the build with mm?


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/