Re: [alsa-cvslog] CVS: alsa-kernel/isa cmi8330.c,1.10,1.11

Re: [alsa-cvslog] CVS: alsa-kernel/isa cmi8330.c,1.10,1.11

[Thierry Vignaud]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Jaroslav Kysela <perex@users.sourceforge.net> writes:

> Update of /cvsroot/alsa/alsa-kernel/isa
> In directory usw-pr-cvs1:/tmp/cvs-serv22649
>
> Modified Files:
> 	cmi8330.c 
> Log Message:
> fix nor non-IsaPnP build

wouldn't something like this (untesterd) be better than redefining
isapnp_* ?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: cmi_vs_isa.diff --]
[-- Type: text/x-patch, Size: 963 bytes --]

Index: isa/Config.in
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/isa/Config.in,v
retrieving revision 1.6
diff -u -3 -p -r1.6 Config.in
--- isa/Config.in	24 Jul 2002 10:42:17 -0000	1.6
+++ isa/Config.in	16 Sep 2002 07:19:37 -0000
@@ -28,7 +28,7 @@ fi
 dep_tristate 'Turtle Beach Maui,Tropez,Tropez+ (Wavefront)' CONFIG_SND_WAVEFRONT $CONFIG_SND
 dep_tristate 'Avance Logic ALS100/ALS120' CONFIG_SND_ALS100 $CONFIG_SND $CONFIG_ISAPNP
 dep_tristate 'Aztech Systems AZT2320' CONFIG_SND_AZT2320 $CONFIG_SND $CONFIG_ISAPNP
-dep_tristate 'C-Media CMI8330' CONFIG_SND_CMI8330 $CONFIG_SND
+dep_tristate 'C-Media CMI8330' CONFIG_SND_CMI8330 $CONFIG_SND CONFIG_ISAPNP
 dep_tristate 'Diamond Technologies DT-019X, Avance Logic ALS-007' CONFIG_SND_DT019X $CONFIG_SND $CONFIG_ISAPNP
 dep_tristate 'Yamaha OPL3-SA2/SA3' CONFIG_SND_OPL3SA2 $CONFIG_SND
 dep_tristate 'Aztech Sound Galaxy' CONFIG_SND_SGALAXY $CONFIG_SND

Re: Re: [alsa-cvslog] CVS: alsa-kernel/isa cmi8330.c,1.10,1.11

[Takashi Iwai]

At Mon, 16 Sep 2002 09:22:55 +0200,
Thierry Vignaud wrote:
> 
> Jaroslav Kysela <perex@users.sourceforge.net> writes:
> 
> > Update of /cvsroot/alsa/alsa-kernel/isa
> > In directory usw-pr-cvs1:/tmp/cvs-serv22649
> >
> > Modified Files:
> > 	cmi8330.c 
> > Log Message:
> > fix nor non-IsaPnP build
> 
> wouldn't something like this (untesterd) be better than redefining
> isapnp_* ?

cmi8330 works even without isapnp.  hence CONFIG_ISAPNP should not be
added in config.in.

but it's true for some other devices (als100, azt2320, dt019x) which
support _only_ isapnp.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Re: [alsa-cvslog] CVS: alsa-kernel/isa cmi8330.c,1.10,1.11

[Thierry Vignaud]

Takashi Iwai <tiwai@suse.de> writes:

> cmi8330 works even without isapnp.  hence CONFIG_ISAPNP should not
> be added in config.in.

for all models ?
i had once a cmi8330 (well something like four years ago) and at that
time it would only works after playing with isapnptools.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Re: [alsa-cvslog] CVS: alsa-kernel/isa cmi8330.c,1.10,1.11

[Takashi Iwai]

At Mon, 16 Sep 2002 12:51:11 +0200,
Thierry Vignaud wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> 
> > cmi8330 works even without isapnp.  hence CONFIG_ISAPNP should not
> > be added in config.in.
> 
> for all models ?

not sure...

> i had once a cmi8330 (well something like four years ago) and at that
> time it would only works after playing with isapnptools.

then CONFIG_ISAPNP should not be in the dependency list.  the driver
wouldn't be compiled once if CONFIG_ISAPNP=n, even though you could
use the card with help of isapnptools.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Re: [alsa-cvslog] CVS: alsa-kernel/isa cmi8330.c,1.10,1.11

[Thierry Vignaud]

Takashi Iwai <tiwai@suse.de> writes:

> > > cmi8330 works even without isapnp.  hence CONFIG_ISAPNP should
> > > not be added in config.in.
> > 
> > for all models ?
>
> not sure...
>
> > i had once a cmi8330 (well something like four years ago) and at
> > that time it would only works after playing with isapnptools.
>
> then CONFIG_ISAPNP should not be in the dependency list.  the driver
> wouldn't be compiled once if CONFIG_ISAPNP=n, even though you could
> use the card with help of isapnptools.

but alsa donation of isapnp to the core kernel made isapnptools
obsoloted since.

anyway, i've no problem with the original patch if some cards works
without isapnp support.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: Re: [alsa-cvslog] CVS: alsa-kernel/isa cmi8330.c,1.10,1.11

[Takashi Iwai]

At Mon, 16 Sep 2002 18:00:50 +0200,
Thierry Vignaud wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> 
> > > > cmi8330 works even without isapnp.  hence CONFIG_ISAPNP should
> > > > not be added in config.in.
> > > 
> > > for all models ?
> >
> > not sure...
> >
> > > i had once a cmi8330 (well something like four years ago) and at
> > > that time it would only works after playing with isapnptools.
> >
> > then CONFIG_ISAPNP should not be in the dependency list.  the driver
> > wouldn't be compiled once if CONFIG_ISAPNP=n, even though you could
> > use the card with help of isapnptools.
> 
> but alsa donation of isapnp to the core kernel made isapnptools
> obsoloted since.

yes but users can still choose not to build isapnp support into the
kernel.  and with your patch (btw you forgot $ before CONFIG_ISAPNP),
the cmi8330 module will not be _built_ in such a case.  that's the
problem.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf