Re: [PATCH v2] ALSA: usb-audio: Reorder snd_djm_devices[] entries

[Takashi Iwai <tiwai@suse.de>]

On Sat, 04 Dec 2021 19:52:24 +0100,
Geraldo Nascimento wrote:
> 
> Olivia Mackintosh has posted to alsa-devel reporting that
> there's a potential bug that could break mixer quirks for Pioneer
> devices introduced by 6d27788160362a7ee6c0d317636fe4b1ddbe59a7
> "ALSA: usb-audio: Add support for the Pioneer DJM 750MK2
> Mixer/Soundcard".
> 
> This happened because the DJM 750 MK2 was added last to the Pioneer DJM
> device table index and defined as 0x4 but was added to snd_djm_devices[]
> just after the DJM 750 (MK1) entry instead of last, after the DJM 900
> NXS2. This escaped review.
> 
> To prevent that from ever happening again, Takashi Iwai suggested to use
> C99 array designators in snd_djm_devices[] instead of simply reordering
> the entries.
> 
> Reported-by: Olivia Mackintosh <livvy@base.nu>
> Suggested-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Geraldo Nascimento <geraldogabriel@gmail.com>
> 
> ---
> 
> V1 -> V2: added C99 array designators to prevent the order of entries
> ever being an issue again.

Thanks, applied now with Fixes tag.


Takashi