From: Takashi Iwai <tiwai@suse.de>
To: Nathan Chancellor <nathan@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 1/2] ALSA: hda/sigmatel - Sink stac_shutup() into stac_suspend()
Date: Wed, 18 Aug 2021 07:51:40 +0200 [thread overview]
Message-ID: <s5hpmubcnbn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210818012705.311963-1-nathan@kernel.org>
On Wed, 18 Aug 2021 03:27:04 +0200,
Nathan Chancellor wrote:
>
> When CONFIG_PM is not set, there is an unused function warning:
>
> sound/pci/hda/patch_sigmatel.c:4383:13: warning: unused function
> 'stac_shutup' [-Wunused-function]
> static void stac_shutup(struct hda_codec *codec)
> ^
> 1 warning generated.
>
> Sink the contents of stac_shutup() into stac_suspend() since
> stac_shutup() is only called in that one location now.
>
> Fixes: 327b34f2a97d ("ALSA: hda: Nuke unused reboot_notify callback")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Thanks, applied.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: hda/sigmatel - Sink stac_shutup() into stac_suspend()
Date: Wed, 18 Aug 2021 07:51:40 +0200 [thread overview]
Message-ID: <s5hpmubcnbn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210818012705.311963-1-nathan@kernel.org>
On Wed, 18 Aug 2021 03:27:04 +0200,
Nathan Chancellor wrote:
>
> When CONFIG_PM is not set, there is an unused function warning:
>
> sound/pci/hda/patch_sigmatel.c:4383:13: warning: unused function
> 'stac_shutup' [-Wunused-function]
> static void stac_shutup(struct hda_codec *codec)
> ^
> 1 warning generated.
>
> Sink the contents of stac_shutup() into stac_suspend() since
> stac_shutup() is only called in that one location now.
>
> Fixes: 327b34f2a97d ("ALSA: hda: Nuke unused reboot_notify callback")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Thanks, applied.
Takashi
next prev parent reply other threads:[~2021-08-18 5:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 1:27 [PATCH 1/2] ALSA: hda/sigmatel - Sink stac_shutup() into stac_suspend() Nathan Chancellor
2021-08-18 1:27 ` Nathan Chancellor
2021-08-18 1:27 ` [PATCH 2/2] ALSA: hda/analog - Sink ad198x_shutup() and shuffle CONFIG_PM guards Nathan Chancellor
2021-08-18 1:27 ` Nathan Chancellor
2021-08-18 5:51 ` Takashi Iwai
2021-08-18 5:51 ` Takashi Iwai
2021-08-18 5:51 ` Takashi Iwai [this message]
2021-08-18 5:51 ` [PATCH 1/2] ALSA: hda/sigmatel - Sink stac_shutup() into stac_suspend() Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpmubcnbn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.