From: Takashi Iwai <tiwai@suse.de>
To: Simon McVittie <smcv@debian.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] Version-check libtool correctly when doing an out-of-tree build
Date: Sun, 17 Oct 2010 11:05:59 +0200 [thread overview]
Message-ID: <s5hpqv9ur2g.wl%tiwai@suse.de> (raw)
In-Reply-To: <20101008080629.GA11076@reptile.pseudorandom.co.uk>
At Fri, 8 Oct 2010 09:06:29 +0100,
Simon McVittie wrote:
>
> libtool is only created at the end of ./configure, so it doesn't make
> sense to grep it in ./configure (the check would always fail the first
> time). However, ltmain.sh is copied into the ${srcdir} by libtoolize and
> should be safe to check at any time that configure can be run.
>
> Signed-off-by: Simon McVittie <smcv@debian.org>
Applied now. Thanks.
Takashi
> ---
> configure.in | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure.in b/configure.in
> index abc4687..e904956 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -115,7 +115,7 @@ AC_ARG_WITH(versioned,
> versioned="$withval", versioned="yes")
> if test "$versioned" = "yes"; then
> # it seems that GNU ld versions since 2.10 are not broken
> - xres=`grep '^VERSION=' libtool | cut -d = -f 2 | cut -d \" -f 2`
> + xres=`grep '^VERSION=' ${srcdir}/ltmain.sh | cut -d = -f 2 | cut -d \" -f 2`
> major=`echo $xres | cut -d . -f 1`
> minor=`echo $xres | cut -d . -f 2`
> pass=0
> --
> 1.7.1
>
> [1.2 Digital signature <application/pgp-signature (7bit)>]
>
> [2 <text/plain; us-ascii (7bit)>]
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2010-10-17 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 8:06 [PATCH 1/2] Version-check libtool correctly when doing an out-of-tree build Simon McVittie
2010-10-17 9:05 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpqv9ur2g.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=smcv@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.