All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ALSA: pcm: Test for "silence" field in struct "pcm_format_data"
Date: Mon, 11 Apr 2022 09:30:53 +0200	[thread overview]
Message-ID: <s5hr164cc0i.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220409012655.9399-1-fmdefrancesco@gmail.com>

On Sat, 09 Apr 2022 03:26:55 +0200,
Fabio M. De Francesco wrote:
> 
> Syzbot reports "KASAN: null-ptr-deref Write in
> snd_pcm_format_set_silence".[1]
> 
> It is due to missing validation of the "silence" field of struct
> "pcm_format_data" in "pcm_formats" array.
> 
> Add a test for valid "pat" and, if it is not so, return -EINVAL.
> 
> [1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/
> 
> Reported-and-tested-by: syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>

Thanks, applied now.


> ---
> 
> I wasn't able to figure out the commit for the "Fixes:" tag. If this patch
> is good, can someone please help with providing this missing information?

That must be present from the very beginning.
I just add Cc-to-stable for allowing backport to all releases.


thanks,

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com
Subject: Re: [PATCH] ALSA: pcm: Test for "silence" field in struct "pcm_format_data"
Date: Mon, 11 Apr 2022 09:30:53 +0200	[thread overview]
Message-ID: <s5hr164cc0i.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220409012655.9399-1-fmdefrancesco@gmail.com>

On Sat, 09 Apr 2022 03:26:55 +0200,
Fabio M. De Francesco wrote:
> 
> Syzbot reports "KASAN: null-ptr-deref Write in
> snd_pcm_format_set_silence".[1]
> 
> It is due to missing validation of the "silence" field of struct
> "pcm_format_data" in "pcm_formats" array.
> 
> Add a test for valid "pat" and, if it is not so, return -EINVAL.
> 
> [1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/
> 
> Reported-and-tested-by: syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>

Thanks, applied now.


> ---
> 
> I wasn't able to figure out the commit for the "Fixes:" tag. If this patch
> is good, can someone please help with providing this missing information?

That must be present from the very beginning.
I just add Cc-to-stable for allowing backport to all releases.


thanks,

Takashi

  reply	other threads:[~2022-04-11  7:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09  1:26 [PATCH] ALSA: pcm: Test for "silence" field in struct "pcm_format_data" Fabio M. De Francesco
2022-04-09  1:26 ` Fabio M. De Francesco
2022-04-11  7:30 ` Takashi Iwai [this message]
2022-04-11  7:30   ` Takashi Iwai
2022-06-14  9:58 ` Eugeniu Rosca
2022-06-14  9:58   ` Eugeniu Rosca
2022-06-14 10:27   ` Takashi Iwai
2022-06-14 10:27     ` Takashi Iwai
2022-06-14 10:43   ` Fabio M. De Francesco
2022-06-14 10:43     ` Fabio M. De Francesco
2022-06-14 10:48     ` Eugeniu Rosca
2022-06-14 10:48       ` Eugeniu Rosca
2022-06-14 10:49     ` Takashi Iwai
2022-06-14 10:49       ` Takashi Iwai
2022-06-14 11:30       ` Fabio M. De Francesco
2022-06-14 11:30         ` Fabio M. De Francesco
2022-06-14 11:46         ` Takashi Iwai
2022-06-14 11:46           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr164cc0i.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fmdefrancesco@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.