All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: cs46xx: add a new line
Date: Wed, 07 Dec 2016 12:59:19 +0100	[thread overview]
Message-ID: <s5hr35kosq0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20161207112250.GD5507@elgon.mountain>

On Wed, 07 Dec 2016 12:22:50 +0100,
Dan Carpenter wrote:
> 
> We accidentally deleted a newline so now the "nreallocated++;" statement
> is hanging out way off to the right of the screen.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.


Takashi

> 
> diff --git a/sound/pci/cs46xx/dsp_spos.c b/sound/pci/cs46xx/dsp_spos.c
> index 4a0cbd2241d8..aa61615288ff 100644
> --- a/sound/pci/cs46xx/dsp_spos.c
> +++ b/sound/pci/cs46xx/dsp_spos.c
> @@ -107,7 +107,8 @@ static int shadow_and_reallocate_code (struct snd_cs46xx * chip, u32 * data, u32
>              
>  						dev_dbg(chip->card->dev,
>  							"handle_wideop:[2] %05x:%05x addr %04x\n",
> -							hival, loval, address);						nreallocated++;
> +							hival, loval, address);
> +						nreallocated++;
>  					} /* wide_opcodes[j] == wide_op */
>  				} /* for */
>  			} /* mod_type == 0 ... */
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: cs46xx: add a new line
Date: Wed, 07 Dec 2016 11:59:19 +0000	[thread overview]
Message-ID: <s5hr35kosq0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20161207112250.GD5507@elgon.mountain>

On Wed, 07 Dec 2016 12:22:50 +0100,
Dan Carpenter wrote:
> 
> We accidentally deleted a newline so now the "nreallocated++;" statement
> is hanging out way off to the right of the screen.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.


Takashi

> 
> diff --git a/sound/pci/cs46xx/dsp_spos.c b/sound/pci/cs46xx/dsp_spos.c
> index 4a0cbd2241d8..aa61615288ff 100644
> --- a/sound/pci/cs46xx/dsp_spos.c
> +++ b/sound/pci/cs46xx/dsp_spos.c
> @@ -107,7 +107,8 @@ static int shadow_and_reallocate_code (struct snd_cs46xx * chip, u32 * data, u32
>              
>  						dev_dbg(chip->card->dev,
>  							"handle_wideop:[2] %05x:%05x addr %04x\n",
> -							hival, loval, address);						nreallocated++;
> +							hival, loval, address);
> +						nreallocated++;
>  					} /* wide_opcodes[j] = wide_op */
>  				} /* for */
>  			} /* mod_type = 0 ... */
> 

  reply	other threads:[~2016-12-07 11:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07 11:22 [patch] ALSA: cs46xx: add a new line Dan Carpenter
2016-12-07 11:22 ` Dan Carpenter
2016-12-07 11:59 ` Takashi Iwai [this message]
2016-12-07 11:59   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr35kosq0.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.