All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Lydia Wang <lydiawang@viatech.com.cn>
Cc: alsa-devel@alsa-project.org, HaraldWelte@viatech.com
Subject: Re: [PATCH 2/16] ALSA: VIA HDA: Add support for VT1802
Date: Mon, 21 Mar 2011 13:00:32 +0100	[thread overview]
Message-ID: <s5hr5a0r8db.wl%tiwai@suse.de> (raw)
In-Reply-To: <4D86FCBF.60803@viatech.com.cn>

At Mon, 21 Mar 2011 15:22:39 +0800,
Lydia Wang wrote:
> 
> -	if (spec->codec_type != VT2002P && spec->codec_type != VT1812)
> +	if (spec->codec_type != VT2002P &&
> +		spec->codec_type != VT1812 &&
> +		spec->codec_type != VT1802)

Better to create a new macro, something like:

   #define VT1812_COMPATIBLE(spec) \
	((spec)->codec_type == VT2002P ||\
	 (spec)->codec_type == VT1812 ||\
	 (spec)->codec_type == VT1802)

instead of open-coding in all places.

> +static struct hda_verb vt1802_volume_init_verbs[] = {
> +	/* Special verbs */
> +	/*{0x1, 0xf93, 0xc3},
> +	{0x1, 0xfa2, 0x70},
> +	{0x1, 0xfe0, 0x04},
> +	{0x1, 0xfe3, 0xfc},
> +	{0x1, 0xff0, 0x39},
> +	{0x1, 0xfa1, 0x58},
> +	{0x1, 0xfd9, 0x0b},
> +	{0x1, 0xfdb, 0x20},
> +	{0x1, 0xfb0, 0x2b},*/

Why are these disabled?  And what do they do?


thanks,

Takashi

      reply	other threads:[~2011-03-21 12:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21  7:22 [PATCH 2/16] ALSA: VIA HDA: Add support for VT1802 Lydia Wang
2011-03-21 12:00 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hr5a0r8db.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=HaraldWelte@viatech.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lydiawang@viatech.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.