All of lore.kernel.org
 help / color / mirror / Atom feed
* hda-intel - Add digout to ALC880 F1734 model
@ 2008-11-01 12:43 Michael Gruber
  2008-11-02 11:23 ` Takashi Iwai
  0 siblings, 1 reply; 10+ messages in thread
From: Michael Gruber @ 2008-11-01 12:43 UTC (permalink / raw)
  To: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 1187 bytes --]

Backstory:
The patch "ALSA: hda - Add infrastructure for dynamic stream allocation"
http://git.alsa-project.org/?p=alsa-kmirror.git;a=commit;h=ae32c9fe811fed22715342494c08a11fabc87762
broke the detection of my card. With this patch applied the dmesg output is:

[ 3761.464838] ACPI: PCI Interrupt 0000:00:1b.0[A] -> GSI 16 (level,
low) -> IRQ 16
[ 3761.464863] PCI: Setting latency timer of device 0000:00:1b.0 to 64
[ 3761.499927] ACPI: PCI interrupt for device 0000:00:1b.0 disabled
[ 3761.499945] HDA Intel: probe of 0000:00:1b.0 failed with error -22

When I loaded the module with model=... then it would work only for some
models, but not for others. I found out that the ones which worked were the
ones with a digout. I added the digout to the F1734 model and now it is
working again.

I can't test if the digout is really working because I lack the hardware, but
when I turn on the IEC958 control in the mixer then red light is emitted from
my headphone port.

I will attach a patch that adds digout to this model because this seems the
right thing to do, but I don't know whether there is something wrong with the
aforementioned patch that caused my problem in the first place.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: F1734_digout.patch --]
[-- Type: text/x-diff; name=F1734_digout.patch, Size: 644 bytes --]

hda-intel - Add digout to ALC880 F1734 model

Adds digout to ALC880 F1734 model

Signed-off-by: Michael Gruber <lists.mg@googlemail.com>



diff --git a/pci/hda/patch_realtek.c b/pci/hda/patch_realtek.c
index fb8fae9..944d941 100644
--- a/pci/hda/patch_realtek.c
+++ b/pci/hda/patch_realtek.c
@@ -3284,6 +3284,7 @@ static struct alc_config_preset alc880_presets[] = {
 				alc880_pin_f1734_init_verbs },
 		.num_dacs = ARRAY_SIZE(alc880_f1734_dac_nids),
 		.dac_nids = alc880_f1734_dac_nids,
+		.dig_out_nid = ALC880_DIGOUT_NID,
 		.hp_nid = 0x02,
 		.num_channel_mode = ARRAY_SIZE(alc880_2_jack_modes),
 		.channel_mode = alc880_2_jack_modes,

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2008-11-05  7:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-01 12:43 hda-intel - Add digout to ALC880 F1734 model Michael Gruber
2008-11-02 11:23 ` Takashi Iwai
2008-11-02 16:02   ` Michael Gruber
2008-11-03 13:19     ` Takashi Iwai
2008-11-03 23:50       ` Michael Gruber
2008-11-04  7:38         ` Takashi Iwai
2008-11-04 16:36           ` Michael Gruber
2008-11-04 16:56             ` Takashi Iwai
2008-11-04 22:18               ` Michael Gruber
2008-11-05  7:01                 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.