[PATCH next-20080704] Fix compile error in drivers/net/mv643xx_eth.c

[PATCH next-20080704] Fix compile error in drivers/net/mv643xx_eth.c

[Takashi Iwai]

drivers/net/mv643xx_eth.c: In function 'mv643xx_eth_netpoll':
drivers/net/mv643xx_eth.c:2115: error: 'INT_CAUSE_EXT' undeclared (first use in this function)
drivers/net/mv643xx_eth.c:2115: error: (Each undeclared identifier is reported only once
drivers/net/mv643xx_eth.c:2115: error: for each function it appears in.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

---
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 83a877f..cb2c065 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -2112,7 +2112,8 @@ static void mv643xx_eth_netpoll(struct net_device *dev)
 
 	mv643xx_eth_irq(dev->irq, dev);
 
-	wrl(mp, INT_MASK(mp->port_num), INT_TX_END | INT_RX | INT_CAUSE_EXT);
+	wrl(mp, INT_MASK(mp->port_num),
+	    INT_TX_END | INT_RX | INT_CAUSE_EXT(mp->port_num));
 }
 #endif
 

Re: [PATCH next-20080704] Fix compile error in drivers/net/mv643xx_eth.c

[Lennert Buytenhek]

On Fri, Jul 04, 2008 at 06:32:03PM +0200, Takashi Iwai wrote:

> drivers/net/mv643xx_eth.c: In function 'mv643xx_eth_netpoll':
> drivers/net/mv643xx_eth.c:2115: error: 'INT_CAUSE_EXT' undeclared (first use in this function)
> drivers/net/mv643xx_eth.c:2115: error: (Each undeclared identifier is reported only once
> drivers/net/mv643xx_eth.c:2115: error: for each function it appears in.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> ---
> diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> index 83a877f..cb2c065 100644
> --- a/drivers/net/mv643xx_eth.c
> +++ b/drivers/net/mv643xx_eth.c
> @@ -2112,7 +2112,8 @@ static void mv643xx_eth_netpoll(struct net_device *dev)
>  
>  	mv643xx_eth_irq(dev->irq, dev);
>  
> -	wrl(mp, INT_MASK(mp->port_num), INT_TX_END | INT_RX | INT_CAUSE_EXT);
> +	wrl(mp, INT_MASK(mp->port_num),
> +	    INT_TX_END | INT_RX | INT_CAUSE_EXT(mp->port_num));

You are ORing the _address_ of the interrupt status register into
the interupt mask register.  How do you expect that to work?

This is the proper fix, which I will re-submit shortly:

	http://marc.info/?l=linux-kernel&m=121498695309851&w=2

Re: [PATCH next-20080704] Fix compile error in drivers/net/mv643xx_eth.c

[Takashi Iwai]

At Fri, 4 Jul 2008 18:49:55 +0200,
Lennert Buytenhek wrote:
> 
> On Fri, Jul 04, 2008 at 06:32:03PM +0200, Takashi Iwai wrote:
> 
> > drivers/net/mv643xx_eth.c: In function 'mv643xx_eth_netpoll':
> > drivers/net/mv643xx_eth.c:2115: error: 'INT_CAUSE_EXT' undeclared (first use in this function)
> > drivers/net/mv643xx_eth.c:2115: error: (Each undeclared identifier is reported only once
> > drivers/net/mv643xx_eth.c:2115: error: for each function it appears in.
> > 
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > 
> > ---
> > diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> > index 83a877f..cb2c065 100644
> > --- a/drivers/net/mv643xx_eth.c
> > +++ b/drivers/net/mv643xx_eth.c
> > @@ -2112,7 +2112,8 @@ static void mv643xx_eth_netpoll(struct net_device *dev)
> >  
> >  	mv643xx_eth_irq(dev->irq, dev);
> >  
> > -	wrl(mp, INT_MASK(mp->port_num), INT_TX_END | INT_RX | INT_CAUSE_EXT);
> > +	wrl(mp, INT_MASK(mp->port_num),
> > +	    INT_TX_END | INT_RX | INT_CAUSE_EXT(mp->port_num));
> 
> You are ORing the _address_ of the interrupt status register into
> the interupt mask register.  How do you expect that to work?
> 
> This is the proper fix, which I will re-submit shortly:
> 
> 	http://marc.info/?l=linux-kernel&m=121498695309851&w=2

Just my ignorance, disregard my broken patch.

But why the heck is this still hanging for so long time?  The
linux-next tree is built everyday, and why such an obvious fix isn't 
picked up...?


thanks,

Takashi