Re: pci_disable_device warning

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

At Wed, 17 Nov 2004 13:40:48 -0500,
Lee Revell wrote:
> 
> I get this warning when removing ALSA modules.  I believe the warning is
> going away, so maybe we should address the issue now.  Is this something
> that could be done by the ALSA middle layer? 
 
Possible, but I think better in each driver code.

> Nov 16 23:32:09 krustophenia kernel: EMU10K1_Audigy 0000:00:14.0: Device
> was removed without properly calling pci_disable_device(). This may need
> fixing.
> 
> I tried adding a call to pci_disable_device and the warning persisted,
> maybe I did not add it in the right place.

Does the patch below fix?


Takashi

[-- Attachment #2: Type: text/plain, Size: 554 bytes --]

Index: alsa-kernel/pci/emu10k1/emu10k1_main.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/emu10k1/emu10k1_main.c,v
retrieving revision 1.38
diff -u -r1.38 emu10k1_main.c
--- alsa-kernel/pci/emu10k1/emu10k1_main.c	30 Jul 2004 12:44:58 -0000	1.38
+++ alsa-kernel/pci/emu10k1/emu10k1_main.c	18 Nov 2004 13:05:28 -0000
@@ -561,6 +561,7 @@
 		free_irq(emu->irq, (void *)emu);
 	if (emu->port)
 		pci_release_regions(emu->pci);
+	pci_disable_device(emu->pci);
 	kfree(emu);
 	return 0;
 }