From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
alsa-devel@alsa-project.org, Arnd Bergmann <arnd@arndb.de>,
"David S . Miller" <davem@davemloft.net>,
Cong Wang <xiyou.wangcong@gmail.com>,
Igor Konopko <igor.j.konopko@intel.com>,
Clemens Ladisch <clemens@ladisch.de>,
Matias Bjorling <mb@lightnvm.io>,
linux-afs@lists.infradead.org,
Eran Ben Elisha <eranbe@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
"Mohit P . Tahiliani" <tahiliani@nitk.edu.in>,
Dan Carpenter <dan.carpenter@oracle.com>,
Joe Perches <joe@perches.com>, Jaroslav Kysela <perex@perex.cz>,
David Howells <dhowells@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants
Date: Wed, 29 May 2019 12:07:13 +0200 [thread overview]
Message-ID: <s5hsgsxtvzi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190529095730.GA7089@workstation>
On Wed, 29 May 2019 11:57:31 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On Tue, May 28, 2019 at 04:24:23PM +0200, Geert Uytterhoeven wrote:
> > With gcc 4.1:
> >
> > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_switch_fetching_mode’:
> > sound/firewire/fireface/ff-protocol-latter.c:97: warning: integer constant is too large for ‘long’ type
> > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_begin_session’:
> > sound/firewire/fireface/ff-protocol-latter.c:170: warning: integer constant is too large for ‘long’ type
> > sound/firewire/fireface/ff-protocol-latter.c:197: warning: integer constant is too large for ‘long’ type
> > sound/firewire/fireface/ff-protocol-latter.c:205: warning: integer constant is too large for ‘long’ type
> > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_finish_session’:
> > sound/firewire/fireface/ff-protocol-latter.c:214: warning: integer constant is too large for ‘long’ type
> >
> > Fix this by adding the missing "ULL" suffixes.
> > Add the same suffix to the last constant, to maintain consistency.
> >
> > Fixes: fd1cc9de64c2ca6c ("ALSA: fireface: add support for Fireface UCX")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > sound/firewire/fireface/ff-protocol-latter.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Thanks for your care.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied to sound git tree now. Thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: "Takashi Sakamoto" <o-takashi@sakamocchi.jp>
Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>,
<alsa-devel@alsa-project.org>, "Arnd Bergmann" <arnd@arndb.de>,
"David S . Miller" <davem@davemloft.net>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Igor Konopko" <igor.j.konopko@intel.com>,
"Clemens Ladisch" <clemens@ladisch.de>,
"Matias Bjorling" <mb@lightnvm.io>,
<linux-afs@lists.infradead.org>,
"Eran Ben Elisha" <eranbe@mellanox.com>,
"Jiri Pirko" <jiri@mellanox.com>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Mohit P . Tahiliani" <tahiliani@nitk.edu.in>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Joe Perches" <joe@perches.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"David Howells" <dhowells@redhat.com>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants
Date: Wed, 29 May 2019 12:07:13 +0200 [thread overview]
Message-ID: <s5hsgsxtvzi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190529095730.GA7089@workstation>
On Wed, 29 May 2019 11:57:31 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On Tue, May 28, 2019 at 04:24:23PM +0200, Geert Uytterhoeven wrote:
> > With gcc 4.1:
> >
> > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_switch_fetching_mode’:
> > sound/firewire/fireface/ff-protocol-latter.c:97: warning: integer constant is too large for ‘long’ type
> > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_begin_session’:
> > sound/firewire/fireface/ff-protocol-latter.c:170: warning: integer constant is too large for ‘long’ type
> > sound/firewire/fireface/ff-protocol-latter.c:197: warning: integer constant is too large for ‘long’ type
> > sound/firewire/fireface/ff-protocol-latter.c:205: warning: integer constant is too large for ‘long’ type
> > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_finish_session’:
> > sound/firewire/fireface/ff-protocol-latter.c:214: warning: integer constant is too large for ‘long’ type
> >
> > Fix this by adding the missing "ULL" suffixes.
> > Add the same suffix to the last constant, to maintain consistency.
> >
> > Fixes: fd1cc9de64c2ca6c ("ALSA: fireface: add support for Fireface UCX")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > sound/firewire/fireface/ff-protocol-latter.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Thanks for your care.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied to sound git tree now. Thanks.
Takashi
next prev parent reply other threads:[~2019-05-29 10:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 14:24 [PATCH 0/5] Assorted fixes discovered with gcc 4.1 Geert Uytterhoeven
2019-05-28 14:24 ` [PATCH 1/5] lightnvm: Fix uninitialized pointer in nvm_remove_tgt() Geert Uytterhoeven
2019-05-29 8:08 ` Matias Bjørling
2019-05-29 8:12 ` Geert Uytterhoeven
2019-05-29 8:12 ` Geert Uytterhoeven
2019-05-28 14:24 ` [PATCH 2/5] rxrpc: Fix uninitialized error code in rxrpc_send_data_packet() Geert Uytterhoeven
2019-05-28 16:30 ` David Howells
2019-05-29 11:49 ` Arnd Bergmann
2019-05-29 11:49 ` Arnd Bergmann
2019-05-31 10:34 ` [PATCH] " David Howells
2019-06-03 21:30 ` David Miller
2019-06-03 21:30 ` David Miller
2019-06-04 7:17 ` Geert Uytterhoeven
2019-06-04 7:17 ` Geert Uytterhoeven
2019-06-04 7:34 ` David Howells
2019-06-04 7:34 ` David Howells
2019-06-04 7:35 ` Geert Uytterhoeven
2019-06-04 7:35 ` Geert Uytterhoeven
2019-05-28 14:24 ` [PATCH 3/5] net: sched: pie: Use ULL suffix for 64-bit constant Geert Uytterhoeven
2019-05-29 11:39 ` Arnd Bergmann
2019-05-29 11:39 ` Arnd Bergmann
2019-05-28 14:24 ` [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants Geert Uytterhoeven
2019-05-29 9:57 ` Takashi Sakamoto
2019-05-29 9:57 ` Takashi Sakamoto
2019-05-29 10:07 ` Takashi Iwai [this message]
2019-05-29 10:07 ` Takashi Iwai
2019-05-28 14:24 ` [PATCH 5/5] [RFC] devlink: Fix uninitialized error code in devlink_fmsg_prepare_skb() Geert Uytterhoeven
2019-05-28 14:40 ` Eran Ben Elisha
2019-05-29 8:04 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsgsxtvzi.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=clemens@ladisch.de \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=eranbe@mellanox.com \
--cc=geert@linux-m68k.org \
--cc=igor.j.konopko@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=joe@perches.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=netdev@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tahiliani@nitk.edu.in \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.