From: Takashi Iwai <tiwai@suse.de>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: patches.audio@intel.com, Vinod Koul <vinod.koul@intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH 06/15] ALSA: pcm: Add DRM helper to set constraint for format
Date: Tue, 01 Dec 2015 13:55:03 +0100 [thread overview]
Message-ID: <s5hsi3mpbvc.wl-tiwai@suse.de> (raw)
In-Reply-To: <1448992031-8271-6-git-send-email-subhransu.s.prusty@intel.com>
On Tue, 01 Dec 2015 18:47:02 +0100,
Subhransu S. Prusty wrote:
>
> +static int eld_limit_formats(struct snd_pcm_runtime *runtime, void *eld)
> +{
> + u64 formats = SNDRV_PCM_FMTBIT_S16_LE;
> + int i;
> + const u8 *sad, *eld_buf = eld;
> +
> + sad = drm_eld_sad(eld_buf);
> + if (!sad)
> + goto format_constraint;
> +
> + for (i = drm_eld_sad_count(eld_buf); i > 0; i--, sad += 3) {
> + if (sad_format(sad) == 1) { /* AUDIO_CODING_TYPE_LPCM */
> +
> + /* 20 bit */
> + if (sad_sample_bits_lpcm(sad) & 0x2)
> + formats |= SNDRV_PCM_FMTBIT_S32_LE;
> +
> + /* 24 bit */
> + if (sad_sample_bits_lpcm(sad) & 0x4)
> + formats |= SNDRV_PCM_FMTBIT_S24_LE;
Does it work correctly with HD-audio...?
Takashi
next prev parent reply other threads:[~2015-12-01 12:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 17:42 [PATCH 00/15] ASoC: hdac_hdmi: Add DP & notification support Subhransu S. Prusty
2015-12-01 17:46 ` [PATCH 01/15] ASoC: hdac_hdmi: Fix to check num nodes correctly Subhransu S. Prusty
2015-12-01 12:27 ` Takashi Iwai
2015-12-01 19:08 ` Subhransu S. Prusty
2015-12-01 17:46 ` [PATCH 02/15] ASoC: hdac_hdmi: Fix to warn instead of err for no connected nids Subhransu S. Prusty
2016-01-08 13:44 ` Applied "ASoC: hdac_hdmi: Fix to warn instead of err for no connected nids" to the asoc tree Mark Brown
2015-12-01 17:46 ` [PATCH 03/15] ASoC: hdac_hdmi - Use list to add pins and converters Subhransu S. Prusty
2015-12-01 12:47 ` Takashi Iwai
2015-12-01 22:50 ` Subhransu S. Prusty
2015-12-01 18:52 ` Takashi Iwai
2015-12-02 9:31 ` Takashi Iwai
2015-12-03 10:36 ` Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 04/15] ALSA: hda - Add helper to read eld data Subhransu S. Prusty
2015-12-01 12:39 ` Takashi Iwai
2015-12-01 19:12 ` Subhransu S. Prusty
2015-12-01 13:55 ` Takashi Iwai
2015-12-01 17:47 ` [PATCH 05/15] ASoC: hdac_hdmi: Add hotplug notification and read eld Subhransu S. Prusty
2015-12-01 12:37 ` Takashi Iwai
2015-12-01 20:14 ` Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 06/15] ALSA: pcm: Add DRM helper to set constraint for format Subhransu S. Prusty
2015-12-01 12:55 ` Takashi Iwai [this message]
2015-12-02 12:27 ` Subhransu S. Prusty
2015-12-02 9:23 ` Takashi Iwai
2015-12-01 17:47 ` [PATCH 07/15] ASoC: hdac_hdmi: Apply constraints based on ELD Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 08/15] ASoC: hdac_hdmi: Enable DP1.2 and all converters/pins Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 09/15] ASoC: hdac_hdmi - create dais based on number of streams Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 10/15] ASoC: hdac_hdmi: Create widget/route based on nodes enumerated Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 11/15] ASoC: hdac_hdmi: Assign pin for stream based on dapm connection Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 12/15] drm/edid: Add API to help find connection type Subhransu S. Prusty
2015-12-02 9:53 ` Jani Nikula
2015-12-02 17:07 ` Thierry Reding
2015-12-03 16:08 ` [alsa-devel] " Subhransu S. Prusty
2015-12-03 11:09 ` Jani Nikula
2015-12-03 11:21 ` Thierry Reding
2015-12-03 17:14 ` Subhransu S. Prusty
2015-12-02 17:16 ` Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 13/15] ASoC: hdac_hdmi: Add infoframe support for dp audio Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 14/15] ASoC: hdac_hdmi: Add codec suspend/resume handler Subhransu S. Prusty
2015-12-01 17:47 ` [PATCH 15/15] ASoC: hdac_hdmi: Keep display active while enumerating codec Subhransu S. Prusty
2015-12-01 12:57 ` Takashi Iwai
2015-12-01 21:48 ` Subhransu S. Prusty
2015-12-01 16:33 ` Takashi Iwai
2015-12-01 16:48 ` Babu, Ramesh
2015-12-01 17:08 ` Takashi Iwai
2015-12-02 15:37 ` Subhransu S. Prusty
2015-12-02 10:24 ` Takashi Iwai
2015-12-02 10:31 ` Takashi Iwai
2015-12-02 16:23 ` Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsi3mpbvc.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.