Re: [PATCH 04/15] ALSA: hda - Add helper to read eld data

[Takashi Iwai <tiwai@suse.de>]

On Tue, 01 Dec 2015 20:12:14 +0100,
Subhransu S. Prusty wrote:
> 
> On Tue, Dec 01, 2015 at 01:39:19PM +0100, Takashi Iwai wrote:
> > On Tue, 01 Dec 2015 18:47:00 +0100,
> > Subhransu S. Prusty wrote:
> > > 
> > > The eld reading APIs are required for ASoC skylake hdmi
> > > driver as well. So moving these definition to core. Once
> > > component ops for reading ELD is available will mark this
> > > as deprecated.
> > > 
> > > Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
> > > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > 
> > I'd like rather to merge this from my tree, not from asoc tree.
> > Otherwise it makes hard to use this in the legacy HDA driver.
> 
> I have not updated the callers here and not planning to change for now as
> it can be removed I guess once the component framework is available to
> read eld. What do you say?

OK, then you also don't have to put the stuff into the common place,
either, as this stuff won't be used any longer in near future :)


Takashi

> 
> Regards,
> Subhransu
> > 
> > Or make this local in asoc, and clean up later as a common helper.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> > 
> 
> -- 
>