From: Takashi Iwai <tiwai@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Dave Airlie <airlied@linux.ie>,
Brian King <brking@linux.vnet.ibm.com>,
Linux PCI <linux-pci@vger.kernel.org>,
Yijing Wang <wangyijing@huawei.com>,
Anton Blanchard <anton@au1.ibm.com>,
linuxppc-dev@ozlabs.org, Alex Deucher <alexdeucher@gmail.com>
Subject: Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI
Date: Wed, 08 Oct 2014 08:59:40 +0200 [thread overview]
Message-ID: <s5hsiizjbc3.wl-tiwai@suse.de> (raw)
In-Reply-To: <1412746096.30859.229.camel@pasglop>
At Wed, 08 Oct 2014 16:28:16 +1100,
Benjamin Herrenschmidt wrote:
>
> On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote:
> > > This moves the setting of the quirk flag to the audio driver.
> > >
> > > While recent ASICs have that problem fixed, they don't seem to
> > > be listed in the PCI IDs of the current driver, so let's quirk all
> > > the ATI HDMI for now. The consequences are nil on x86 anyway.
> > >
> > > Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > CC: <stable@vger.kernel.org>
> >
> > Further discussion with the hw teams have revealed that this is still
> > an issue on newer asics so I think your original patch is correct
> > after all. Just disable 64 bit MSIs on all AMD audio PCI ids.
>
> Allright, I won't resend the whole series, I can just pickup my previous
> patch. Takashi, Bjorn, Dave, this series covers your 3 areas of
> maintainership, how do you want to proceed ? I'm happy to merge the
> whole lot via powerpc ASAP (since it's all CC'ed stable) if you guys
> send me the appropriate acks, otherwise, let me know.
Feel free to merge through your tree.
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Dave Airlie <airlied@linux.ie>,
Linux PCI <linux-pci@vger.kernel.org>,
Anton Blanchard <anton@au1.ibm.com>,
Brian King <brking@linux.vnet.ibm.com>,
Yijing Wang <wangyijing@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Alex Deucher <alexdeucher@gmail.com>
Subject: Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI
Date: Wed, 08 Oct 2014 08:59:40 +0200 [thread overview]
Message-ID: <s5hsiizjbc3.wl-tiwai@suse.de> (raw)
In-Reply-To: <1412746096.30859.229.camel@pasglop>
At Wed, 08 Oct 2014 16:28:16 +1100,
Benjamin Herrenschmidt wrote:
>
> On Tue, 2014-10-07 at 19:47 -0400, Alex Deucher wrote:
> > > This moves the setting of the quirk flag to the audio driver.
> > >
> > > While recent ASICs have that problem fixed, they don't seem to
> > > be listed in the PCI IDs of the current driver, so let's quirk all
> > > the ATI HDMI for now. The consequences are nil on x86 anyway.
> > >
> > > Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > CC: <stable@vger.kernel.org>
> >
> > Further discussion with the hw teams have revealed that this is still
> > an issue on newer asics so I think your original patch is correct
> > after all. Just disable 64 bit MSIs on all AMD audio PCI ids.
>
> Allright, I won't resend the whole series, I can just pickup my previous
> patch. Takashi, Bjorn, Dave, this series covers your 3 areas of
> maintainership, how do you want to proceed ? I'm happy to merge the
> whole lot via powerpc ASAP (since it's all CC'ed stable) if you guys
> send me the appropriate acks, otherwise, let me know.
Feel free to merge through your tree.
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2014-10-08 6:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 4:38 [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI Benjamin Herrenschmidt
2014-10-07 4:38 ` Benjamin Herrenschmidt
2014-10-07 23:47 ` Alex Deucher
2014-10-07 23:47 ` Alex Deucher
2014-10-07 23:49 ` Benjamin Herrenschmidt
2014-10-07 23:49 ` Benjamin Herrenschmidt
2014-10-08 0:18 ` Alex Deucher
2014-10-08 0:18 ` Alex Deucher
2014-10-08 5:28 ` Benjamin Herrenschmidt
2014-10-08 5:28 ` Benjamin Herrenschmidt
2014-10-08 6:23 ` Alex Deucher
2014-10-08 6:23 ` Alex Deucher
2014-10-08 6:59 ` Takashi Iwai [this message]
2014-10-08 6:59 ` Takashi Iwai
2014-10-13 20:11 ` Benjamin Herrenschmidt
2014-10-13 20:11 ` Benjamin Herrenschmidt
2014-10-13 20:39 ` Alex Deucher
2014-10-13 20:39 ` Alex Deucher
2014-10-13 20:46 ` Bjorn Helgaas
2014-10-13 20:46 ` Bjorn Helgaas
2014-10-15 22:19 ` Bjorn Helgaas
2014-10-15 22:19 ` Bjorn Helgaas
2014-10-15 22:55 ` Benjamin Herrenschmidt
2014-10-15 22:55 ` Benjamin Herrenschmidt
2014-11-11 21:12 ` Bjorn Helgaas
2014-11-11 21:12 ` Bjorn Helgaas
2014-11-12 2:23 ` Michael Ellerman
2014-11-12 2:23 ` Michael Ellerman
2014-11-12 4:06 ` Benjamin Herrenschmidt
2014-11-12 4:06 ` Benjamin Herrenschmidt
2014-11-12 4:09 ` Bjorn Helgaas
2014-11-12 4:09 ` Bjorn Helgaas
2014-11-13 5:19 ` Michael Ellerman
2014-11-13 5:19 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hsiizjbc3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=airlied@linux.ie \
--cc=alexdeucher@gmail.com \
--cc=anton@au1.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.