From: Takashi Iwai <tiwai@suse.de>
To: Chanho Park <chanho61.park@samsung.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>, eunwoo kim <ew.kim@samsung.com>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH] ALSA: pcm: Need to check whether runtime is valid or not
Date: Wed, 12 May 2021 09:08:18 +0200 [thread overview]
Message-ID: <s5htun8bfa5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210512044323.106673-1-chanho61.park@samsung.com>
On Wed, 12 May 2021 06:43:23 +0200,
Chanho Park wrote:
>
> From: eunwoo kim <ew.kim@samsung.com>
>
> Since snd_pcm_ioctl_sw_params_compat has no runtime variable check,
> if application call the ioctl after close, it can make kernel crash.
> So, snd_pcm_ioctl_sw_params_compat needs to check the runtime variable
> at the beginning of the function.
In principle, you cannot call ioctl for an already closed file.
Or do you mean other code path?
Takashi
next prev parent reply other threads:[~2021-05-12 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210512044441epcas2p4ad7c01a1dc9048bd96a9973760017d8c@epcas2p4.samsung.com>
2021-05-12 4:43 ` [PATCH] ALSA: pcm: Need to check whether runtime is valid or not Chanho Park
2021-05-12 7:08 ` Takashi Iwai [this message]
[not found] ` <20210512075834epcms2p182290868ca278decaa7e86c67f740db8@epcms2p1>
[not found] ` <929757006.2969317.1620858694065@mail-kr2-3>
[not found] ` <1932109751.3301982.1620952404404@mail-kr2-3>
[not found] ` <CGME20210512044441epcas2p4ad7c01a1dc9048bd96a9973760017d8c@epcms2p1>
[not found] ` <s5h8s4hahxj.wl-tiwai@suse.de>
[not found] ` <s5ho8df9inv.wl-tiwai@suse.de>
2021-05-19 23:16 ` EUNWOO KIM
2021-05-20 8:10 ` Takashi Iwai
2021-05-24 22:41 ` EUNWOO KIM
2021-05-25 6:51 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htun8bfa5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=chanho61.park@samsung.com \
--cc=ew.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.