All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Sriram Periyasamy <sriramx.periyasamy@intel.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Patches Audio <patches.audio@intel.com>,
	ALSA ML <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
Subject: Re: [PATCH 2/4] ALSA: hda: Make sure DMA is started by reading back the RUN bit
Date: Tue, 15 May 2018 09:36:19 +0200	[thread overview]
Message-ID: <s5htvr94bgs.wl-tiwai@suse.de> (raw)
In-Reply-To: <1526366456-20470-3-git-send-email-sriramx.periyasamy@intel.com>

On Tue, 15 May 2018 08:40:54 +0200,
Sriram Periyasamy wrote:
> 
> From: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
> 
> As per HW recommendation, after setting the RUN bit,
> software must read a 1 from the RUN bit, before modifying
> related control registers/re-starting the DMA engine.

Rather FIFO is checked in snd_hdac_stream_sync(), so I guess it
already suffices.  But we can add this sanity check there, too, if it
really matters.


thanks,

Takashi

  reply	other threads:[~2018-05-15  7:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15  6:40 [PATCH 0/4] ALSA: hda: Bug fixes Sriram Periyasamy
2018-05-15  6:40 ` [PATCH 1/4] ALSA: hda: Make sure DMA is stopped by reading back the RUN bit Sriram Periyasamy
2018-05-15  7:34   ` Takashi Iwai
2018-05-15  6:40 ` [PATCH 2/4] ALSA: hda: Make sure DMA is started " Sriram Periyasamy
2018-05-15  7:36   ` Takashi Iwai [this message]
2018-05-15  6:40 ` [PATCH 3/4] ALSA: hda: Log HDA Hardware related errors Sriram Periyasamy
2018-05-15  7:43   ` Takashi Iwai
2018-05-15  6:40 ` [PATCH 4/4] ALSA: hda: check if stream is stopped in snd_hdac_stream_clear Sriram Periyasamy
2018-05-15  7:41   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htvr94bgs.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=pardha.saradhi.kesapragada@intel.com \
    --cc=patches.audio@intel.com \
    --cc=sriramx.periyasamy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.