Re: [PATCH 3/4] ALSA: hda: Log HDA Hardware related errors

[Takashi Iwai <tiwai@suse.de>]

On Tue, 15 May 2018 08:40:55 +0200,
Sriram Periyasamy wrote:
> 
> From: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
> 
> Detect the timeout while modifying HDA DMA related Registers
> for stream reset and print them to console for user information
> 
> Signed-off-by: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
> Signed-off-by: Sriram Periyasamy <sriramx.periyasamy@intel.com>
> ---
>  sound/hda/hdac_stream.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c
> index 33c8ced528f6..aa8a2884289f 100644
> --- a/sound/hda/hdac_stream.c
> +++ b/sound/hda/hdac_stream.c
> @@ -144,6 +144,10 @@ void snd_hdac_stream_reset(struct hdac_stream *azx_dev)
>  		if (val)
>  			break;
>  	} while (--timeout);
> +
> +	if (!timeout)
> +		dev_err(azx_dev->bus->dev, "timeout on stream reset entry\n");
> +
>  	val &= ~SD_CTL_STREAM_RESET;
>  	snd_hdac_stream_writeb(azx_dev, SD_CTL, val);
>  	udelay(3);
> @@ -157,6 +161,9 @@ void snd_hdac_stream_reset(struct hdac_stream *azx_dev)
>  			break;
>  	} while (--timeout);
>  
> +	if (!timeout)
> +		dev_err(azx_dev->bus->dev, "timeout on stream reset exit\n");

Just from curiosity: did you ever hit these?  Or just because of
consistency?


Takashi