From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
Hardik T Shah <hardik.t.shah@intel.com>,
Guneshwor Singh <guneshwor.o.singh@intel.com>,
liam.r.girdwood@linux.intel.com, broonie@kernel.org
Subject: Re: [PATCH v3 4/5] ALSA - hda: Add support for parsing new HDA capabilities
Date: Thu, 04 Aug 2016 07:46:10 +0200 [thread overview]
Message-ID: <s5htwf1rsrh.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160804055133.GB9681@localhost>
On Thu, 04 Aug 2016 07:51:34 +0200,
Vinod Koul wrote:
>
> On Thu, Aug 04, 2016 at 07:30:59AM +0530, Vinod Koul wrote:
> > > > +
> > > > +#ifdef CONFIG_X86
> > > > + if ((bus->ppcap && boot_cpu_has(X86_FEATURE_ART)))
> > >
> > > Superfluous parentheses.
> > > Also, don't we need to include asm/cpufeature.h?
> >
> > Its somehow included, I will check that part as well
>
> And didnt find how :(
>
> Btw we include asm/pgtable.h which uses boot_cpu_has() macro.
> So somehow it is getting included.
>
> Do you want this be explicitly included?
Yes, it's safer.
Takashi
next prev parent reply other threads:[~2016-08-04 5:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 16:06 [PATCH v3 0/5] ALSA - hda: Add support for link audio time reporting Vinod Koul
2016-08-03 16:06 ` [PATCH v3 1/5] ALSA: hda - move bus_parse_capabilities to core Vinod Koul
2016-08-03 16:09 ` Takashi Iwai
2016-08-04 1:56 ` Vinod Koul
2016-08-03 16:06 ` [PATCH v3 2/5] ALSA: convert users to core bus_parse_capabilities Vinod Koul
2016-08-09 12:44 ` Applied "ALSA: convert users to core bus_parse_capabilities" to the asoc tree Mark Brown
2016-08-03 16:06 ` [PATCH v3 3/5] ALSA - Ext hda: remove bus_parse_capabilities Vinod Koul
2016-08-09 12:44 ` Applied "ALSA - Ext hda: remove bus_parse_capabilities" to the asoc tree Mark Brown
2016-08-03 16:06 ` [PATCH v3 4/5] ALSA - hda: Add support for parsing new HDA capabilities Vinod Koul
2016-08-03 16:11 ` Takashi Iwai
2016-08-04 2:00 ` Vinod Koul
2016-08-04 5:51 ` Vinod Koul
2016-08-04 5:46 ` Takashi Iwai [this message]
2016-08-03 16:06 ` [PATCH v3 5/5] ALSA - hda: Add support for link audio time reporting Vinod Koul
2016-08-03 16:21 ` Takashi Iwai
2016-08-04 2:00 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5htwf1rsrh.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guneshwor.o.singh@intel.com \
--cc=hardik.t.shah@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.