All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] pcm_oss: AFMT_S24_LE is set twice in return value
Date: Wed, 04 Feb 2009 18:26:34 +0100	[thread overview]
Message-ID: <s5htz7a6rlh.wl%tiwai@suse.de> (raw)
In-Reply-To: <4989CD0F.50700@gmail.com>

At Wed, 04 Feb 2009 18:14:55 +0100,
Roel Kluin wrote:
> 
> vi sound/core/oss/pcm_oss.c +640
> #define AFMT_S24_LE      0x00008000
> #define AFMT_S24_BE      0x00010000
> 
> ---------------------->8----------------------8<-------------------
> AFMT_S24_LE is set twice in return value
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Thanks, applied now.


Takashi

> ---
> diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
> index e178366..0a1798e 100644
> --- a/sound/core/oss/pcm_oss.c
> +++ b/sound/core/oss/pcm_oss.c
> @@ -1767,7 +1767,7 @@ static int snd_pcm_oss_get_formats(struct snd_pcm_oss_file *pcm_oss_file)
>  		       AFMT_S8 | AFMT_U16_LE |
>  		       AFMT_U16_BE |
>  			AFMT_S32_LE | AFMT_S32_BE |
> -			AFMT_S24_LE | AFMT_S24_LE |
> +			AFMT_S24_LE | AFMT_S24_BE |
>  			AFMT_S24_PACKED;
>  	params = kmalloc(sizeof(*params), GFP_KERNEL);
>  	if (!params)
> 

      reply	other threads:[~2009-02-04 17:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 17:14 [PATCH] pcm_oss: AFMT_S24_LE is set twice in return value Roel Kluin
2009-02-04 17:26 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5htz7a6rlh.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.