[patch] patch_cm9880.c to support multi-channel

[patch] patch_cm9880.c to support multi-channel

["Tien, C.L. - 田承禮"]

Summary: <fix multi-channel for model==full>
Signed-off-by: ChenLi Tien<cltien@cmedia.com.tw>


Hi,

The patch_cm9880.c can't play side/C/B channels from front panel jacks. I fixed it by adding select pin.

I also added controls in the allout_init array. I wonder what this model for because it is the same as basic_init except the line-in is used as output in allout_init.

I plan to add controls for 5/6 stacks ,  which lacks front panel but has rear 5/6 jacks. Any idea?

Sincerely,
ChenLi Tien


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click

Re: [patch] patch_cm9880.c to support multi-channel

[Lee Revell]

On Fri, 2005-03-25 at 01:53 +0800, "Tien, C.L. - 田承禮" wrote:
> Summary: <fix multi-channel for model==full>
> Signed-off-by: ChenLi Tien<cltien@cmedia.com.tw>
> 
> 
> Hi,
> 
> The patch_cm9880.c can't play side/C/B channels from front panel jacks. I fixed it by adding select pin.
> 
> I also added controls in the allout_init array. I wonder what this model for because it is the same as basic_init except the line-in is used as output in allout_init.
> 
> I plan to add controls for 5/6 stacks ,  which lacks front panel but has rear 5/6 jacks. Any idea?
> 
> Sincerely,
> ChenLi Tien

Was there supposed to be a patch attached?

Lee



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click

RE: [patch] patch_cm9880.c to support multi-channel

["Tien, C.L. - 田承禮"]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]


Sorry,

I didn't add the attached file in previous mail, please use this patch. Sorry for any inconvenience.

Sincerely,
ChenLi Tien

-----Original Message-----
From:	Tien,  C.L. - 田承禮
Sent:	2005/3/24 [星期四] 下午 12:53
To:	alsa-devel@alsa-project.org
Cc:	
Subject:	[Alsa-devel] [patch] patch_cm9880.c to support multi-channel

Summary: <fix multi-channel for model==full>
Signed-off-by: ChenLi Tien<cltien@cmedia.com.tw>


Hi,

The patch_cm9880.c can't play side/C/B channels from front panel jacks. I fixed it by adding select pin.

I also added controls in the allout_init array. I wonder what this model for because it is the same as basic_init except the line-in is used as output in allout_init.

I plan to add controls for 5/6 stacks ,  which lacks front panel but has rear 5/6 jacks. Any idea?

Sincerely,
ChenLi Tien


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=ick
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel






[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch_cmedia.c.patch --]
[-- Type: text/x-patch; name="patch_cmedia.c.patch", Size: 1331 bytes --]

Index: alsa-cvs/alsa-kernel/pci/hda/patch_cmedia.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/hda/patch_cmedia.c,v
retrieving revision 1.6
diff -a -u -r1.6 patch_cmedia.c
--- alsa-cvs/alsa-kernel/pci/hda/patch_cmedia.c	22 Mar 2005 21:00:37 -0000	1.6
+++ alsa-cvs/alsa-kernel/pci/hda/patch_cmedia.c	24 Mar 2005 17:43:22 -0000
@@ -278,8 +278,10 @@
 	{ 0x0e, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
 	/* port-G for CLFE (rear panel) */
 	{ 0x1f, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+	{ 0x1f, AC_VERB_SET_CONNECT_SEL, 0x02 },
 	/* port-H for side (rear panel) */
 	{ 0x20, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+	{ 0x20, AC_VERB_SET_CONNECT_SEL, 0x01 },
 	/* port-C for line-in (rear panel) */
 	{ 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, 0x20 },
 	/* port-B for mic-in (rear panel) with vref */
@@ -305,6 +307,10 @@
 	{ 0x0e, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
 	/* port-G for CLFE (rear panel) */
 	{ 0x1f, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+	{ 0x1f, AC_VERB_SET_CONNECT_SEL, 0x02 },
+	/* port-H for side (rear panel) */
+	{ 0x20, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
+	{ 0x20, AC_VERB_SET_CONNECT_SEL, 0x01 },
 	/* port-C for surround (rear panel) */
 	{ 0x0c, AC_VERB_SET_PIN_WIDGET_CONTROL, 0xc0 },
 	/* port-B for mic-in (rear panel) with vref */

Re: [patch] patch_cm9880.c to support multi-channel

[Takashi Iwai]

At Fri, 25 Mar 2005 01:53:06 +0800,
Tien, C.L. wrote:
> 
> I also added controls in the allout_init array. I wonder what this
> model for because it is the same as basic_init except the line-in is
> used as output in allout_init. 

It was coded so, just based on the example configuration described in 
the datasheet of CMI9880, in case any hardware is implemented in that
way.  Surely we can clean up these models.

> I plan to add controls for 5/6 stacks ,  which lacks front panel but
> has rear 5/6 jacks. Any idea? 

Go ahead, let's discuss together with the code :)


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Re: [patch] patch_cm9880.c to support multi-channel

[Takashi Iwai]

At Fri, 25 Mar 2005 03:52:01 +0800,
Tien, C.L. wrote:
> 
> Sorry,
> 
> I didn't add the attached file in previous mail, please use this
> patch. Sorry for any inconvenience. 

No problem.  Applied to CVS now.

Thanks!


Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

RE: [patch] patch_cm9880.c to support multi-channel

["Tien, C.L. - 田承禮"]

I got configuration info from Windows driver's .INI file, there are totally 28 configuration so I think it is impractical to use parameter to fits user's needs.

I want to add configuration for 6-stack first since most of the M/Bs have them.

Then I plan to add code to probe the jacks for multi-channel playback, so driver can find which pin for front/rear/side/LFE by itself without parameter help. The line-out/line-in/mic etc. should also can be detected without a fixed table.

Sincerely,
ChenLi Tien


-----Original Message-----
From:	Takashi Iwai [mailto:tiwai@suse.de]
Sent:	2005/3/24 [星期四] 下午 03:40
To:	Tien,  C.L. - 田承禮
Cc:	alsa-devel@alsa-project.org
Subject:	Re: [Alsa-devel] [patch] patch_cm9880.c to support multi-channel
At Fri, 25 Mar 2005 01:53:06 +0800,
Tien, C.L. wrote:
> 
> I also added controls in the allout_init array. I wonder what this
> model for because it is the same as basic_init except the line-in is
> used as output in allout_init. 

It was coded so, just based on the example configuration described in 
the datasheet of CMI9880, in case any hardware is implemented in that
way.  Surely we can clean up these models.

> I plan to add controls for 5/6 stacks ,  which lacks front panel but
> has rear 5/6 jacks. Any idea? 

Go ahead, let's discuss together with the code :)


Takashi





-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click

Re: [patch] patch_cm9880.c to support multi-channel

[Takashi Iwai]

At Sun, 27 Mar 2005 23:19:02 +0800,
Tien, C.L. wrote:
> 
> I got configuration info from Windows driver's .INI file, there are
> totally 28 configuration so I think it is impractical to use parameter
> to fits user's needs. 
> 
> I want to add configuration for 6-stack first since most of the M/Bs
> have them. 

OK, that's fine.  A patch would be appreciated as always ;)

> Then I plan to add code to probe the jacks for multi-channel
> playback, so driver can find which pin for front/rear/side/LFE by 
> itself without parameter help. The line-out/line-in/mic etc. should 
> also can be detected without a fixed table. 

That's exactly what I wanted to implement after 1.0.9, too.

The basic infrastructure for unsolicited events is already implemented
as a callback to driver, but it's never tested yet.

My another plan for HD-audio is to add the hwdep interface to allow
users reconfigure the mixer interface (like .INI file of windows).
This will require a relatively big rewrite...


Takashi

> 
> Sincerely,
> ChenLi Tien
> 
> 
> -----Original Message-----
> From:	Takashi Iwai [mailto:tiwai@suse.de]
> Sent:	2005/3/24 [星期四] 下午 03:40
> To:	Tien,  C.L. - 田承禮
> Cc:	alsa-devel@alsa-project.org
> Subject:	Re: [Alsa-devel] [patch] patch_cm9880.c to support multi-channel
> At Fri, 25 Mar 2005 01:53:06 +0800,
> Tien, C.L. wrote:
> > 
> > I also added controls in the allout_init array. I wonder what this
> > model for because it is the same as basic_init except the line-in is
> > used as output in allout_init. 
> 
> It was coded so, just based on the example configuration described in 
> the datasheet of CMI9880, in case any hardware is implemented in that
> way.  Surely we can clean up these models.
> 
> > I plan to add controls for 5/6 stacks ,  which lacks front panel but
> > has rear 5/6 jacks. Any idea? 
> 
> Go ahead, let's discuss together with the code :)
> 
> 
> Takashi
> 
> 
> 
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel
> 


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click