PATCH - Typo ??? Line 2 on LiveDrive not working ???

PATCH - Typo ??? Line 2 on LiveDrive not working ???

[p z oooo]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: TEXT/plain; CHARSET=US-ASCII, Size: 514 bytes --]

Hi,

In this mailing list was message that Line2 on LiveDrive is not 
working. I think there is typo in driver (copy & paste typo). There 
are created controls with same control names for line1 and line2 of 
LiveDrive and then controls for Line2 are not created (maybe are 
overwriten). Attached patch is not tested.

Peter Zubaj



====================== REKLAMA =================================
Neobmedzený rýchly prístup na internet u¾ od 666,- Sk mesaène!
Nextra ADSLink. http://adsl.nextra.sk

[-- Attachment #2: C:\live2.diff --]
[-- Type: APPLICATION/octet-stream, Size: 1096 bytes --]

--- o/emufx.c	2003-11-07 18:52:01.000000000 +0100
+++ n/emufx.c	2003-11-26 18:48:51.000000000 +0100
@@ -1948,7 +1948,7 @@
 		/* Line LiveDrive Playback Volume */
 		for (z = 0; z < 2; z++)
 			VOLUME_ADDIN(icode, &ptr, playback + z, EXTIN_LINE2_L + z, gpr + z);
-		snd_emu10k1_init_stereo_control(controls + i++, "Line LiveDrive Playback Volume", gpr, 0);
+		snd_emu10k1_init_stereo_control(controls + i++, "Line2 LiveDrive Playback Volume", gpr, 0);
 		controls[i-1].id.index = 1;
 		gpr += 2;
 	
@@ -1957,8 +1957,8 @@
 			SWITCH_IN(icode, &ptr, tmp + 0, EXTIN_LINE2_L + z, gpr + 2 + z);
 			VOLUME_ADD(icode, &ptr, capture + z, tmp + 0, gpr + z);
 		}
-		snd_emu10k1_init_stereo_control(controls + i++, "Line LiveDrive Capture Volume", gpr, 0);
-		snd_emu10k1_init_stereo_onoff_control(controls + i++, "Line LiveDrive Capture Switch", gpr + 2, 0);
+		snd_emu10k1_init_stereo_control(controls + i++, "Line2 LiveDrive Capture Volume", gpr, 0);
+		snd_emu10k1_init_stereo_onoff_control(controls + i++, "Line2 LiveDrive Capture Switch", gpr + 2, 0);
 		controls[i-1].id.index = 1;
 		gpr += 4;
 	}

Re: PATCH - Typo ??? Line 2 on LiveDrive not working ???

[Takashi Iwai]

At Thu, 27 Nov 2003 08:00:01 +0100,
p z oooo wrote:
> 
> [1  <text/plain; US-ASCII (quoted-printable)>]
> Hi,
> 
> In this mailing list was message that Line2 on LiveDrive is not 
> working. I think there is typo in driver (copy & paste typo). There 
> are created controls with same control names for line1 and line2 of 
> LiveDrive and then controls for Line2 are not created (maybe are 
> overwriten). Attached patch is not tested.

yep, it's an obvious mistake.
applied to cvs.


thanks,

Takashi


-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive?  Does it
help you create better code?  SHARE THE LOVE, and help us help
YOU!  Click Here: http://sourceforge.net/donate/