From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: vinod.koul@intel.com, bardliao@realtek.com,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 3/3] ASoC: Intel: cht_bsw_rt5672: fix card name
Date: Fri, 08 Sep 2017 10:16:23 +0200 [thread overview]
Message-ID: <s5hvaktfvvs.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170908011256.7706-4-pierre-louis.bossart@linux.intel.com>
On Fri, 08 Sep 2017 03:12:56 +0200,
Pierre-Louis Bossart wrote:
>
> For now reason the current card name is a ridiculous
> 'cherrytrailcraudio'. This isn't very useful or self-explanatory,
> change to driver name cht-bsw-rt5672.
One bonus by this change would be to avoid inconsistent names by the
driver's name string size. Since it's 16 bytes including \0, the
name is shortened as cherrytrailcrau or such in some fields. With the
new name this shouldn't happen.
In anyway,
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2017-09-08 8:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 1:12 [PATCH 0/3] Intel-rt5670 updates Pierre-Louis Bossart
2017-09-08 1:12 ` [PATCH 1/3] ASoC: rt5670: refactor DMI quirks and fix Dell Venue settings Pierre-Louis Bossart
2017-09-08 8:12 ` Takashi Iwai
2017-09-25 16:16 ` Applied "ASoC: rt5670: refactor DMI quirks and fix Dell Venue settings" to the asoc tree Mark Brown
2017-09-08 1:12 ` [PATCH 2/3] ASoC: Intel: cht_bsw_rt5672: use actual HID in suspend/resume Pierre-Louis Bossart
2017-09-08 1:12 ` [PATCH 3/3] ASoC: Intel: cht_bsw_rt5672: fix card name Pierre-Louis Bossart
2017-09-08 8:16 ` Takashi Iwai [this message]
2017-09-08 4:08 ` [PATCH 0/3] Intel-rt5670 updates Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvaktfvvs.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.