Patch for ali5451 (ATI IGP chipset) "ali_codec_ready: codec is not ready"

Patch for ali5451 (ATI IGP chipset) "ali_codec_ready: codec is not ready"

[ANDREI LAHUN]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Hello.
Since i bought new laptop (Packard bell igo 3xxx) (ATI
IGP chipset, ALI 5451 sound) i had a problems with a
sound .Trident from OSS worked but quality was not
good. Alsa always hunged with messages (during
modprobe) -
"ali_codec_ready: codec is not ready" all over the
place. Finally i found a fix - to make it work like in
trident OSS driver. For me now alsa works perfectly
in native mode and in OSS emulation. Thank u for great
drivers!

Andrei

__________________________________________________
Do you Yahoo!?
Yahoo! Platinum - Watch CBS' NCAA March Madness, live on your desktop!
http://platinum.yahoo.com

[-- Attachment #2: ali5451_codec_ready.patch --]
[-- Type: application/octet-stream, Size: 877 bytes --]

--- alsa-driver-0.9.2/alsa-kernel/pci/ali5451/ali5451.c	Tue Feb 25 14:35:43 2003
+++ alsa-driver-0.9.2-mod/alsa-kernel/pci/ali5451/ali5451.c	Tue Mar 25 00:26:53 2003
@@ -376,16 +376,19 @@
 				int sched )
 {
 	signed long end_time;
+	unsigned long res;
 	
 	end_time = jiffies + 10 * (HZ >> 2);
 	do {
-		if (!(snd_ali_5451_peek(codec,port) & 0x8000))
+		res = snd_ali_5451_peek(codec,port);
+		if (!(res & 0x8000))
 			return 0;
 		if (sched) {
 			set_current_state(TASK_UNINTERRUPTIBLE);
 			schedule_timeout(1);
 		}
 	} while (end_time - (signed long)jiffies >= 0);
+	snd_ali_5451_poke(codec,port, res & 0x7fff);
 	snd_printk("ali_codec_ready: codec is not ready.\n ");
 	return -EIO;
 }
@@ -408,6 +411,9 @@
 			schedule_timeout(1);
 		}
 	} while (end_time - (signed long)jiffies >= 0);
+	
+	
+	
 	snd_printk("ali_stimer_read: stimer is not ready.\n");
 	return -EIO;
 }

Re: Patch for ali5451 (ATI IGP chipset) "ali_codec_ready: codec is not ready"

[Takashi Iwai]

At Sat, 29 Mar 2003 08:25:02 -0800 (PST),
ANDREI LAHUN wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> Hello.
> Since i bought new laptop (Packard bell igo 3xxx) (ATI
> IGP chipset, ALI 5451 sound) i had a problems with a
> sound .Trident from OSS worked but quality was not
> good. Alsa always hunged with messages (during
> modprobe) -
> "ali_codec_ready: codec is not ready" all over the
> place. Finally i found a fix - to make it work like in
> trident OSS driver. For me now alsa works perfectly
> in native mode and in OSS emulation. Thank u for great
> drivers!

thanks, i committed your patch to cvs.
i changed the bit-and value to ~0x8000, since the alsa driver uses
outl() for accessing while oss uses outw().
to be sure, please check whether the latest driver works for you.


ciao,

Takashi


-------------------------------------------------------
This SF.net email is sponsored by: ValueWeb: 
Dedicated Hosting for just $79/mo with 500 GB of bandwidth! 
No other company gives more support or power for your dedicated server
http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/

Re: Patch for ali5451 (ATI IGP chipset) "ali_codec_ready: codec is not ready"

[ANDREI LAHUN]

--- Takashi Iwai <tiwai@suse.de> wrote:

> 
> thanks, i committed your patch to cvs.
> i changed the bit-and value to ~0x8000, since the
> alsa driver uses
> outl() for accessing while oss uses outw().
> to be sure, please check whether the latest driver
> works for you.
> 
> 
> ciao,
> 
> Takashi
> 
> 
Just checked latest cvs. No problems works good.
thank you.
Andrei.

__________________________________________________
Do you Yahoo!?
Yahoo! Tax Center - File online, calculators, forms, and more
http://tax.yahoo.com


-------------------------------------------------------
This SF.net email is sponsored by: ValueWeb: 
Dedicated Hosting for just $79/mo with 500 GB of bandwidth! 
No other company gives more support or power for your dedicated server
http://click.atdmt.com/AFF/go/sdnxxaff00300020aff/direct/01/