current cvs compile error

current cvs compile error

[Fernando Pablo Lopez-Lezcano]

I _think_ this is the fix, please check (the error is "undeclared
variable ctl")...

--- alsa-kernel/core/timer.c~	2003-02-06 11:21:11.000000000 -0800
+++ alsa-kernel/core/timer.c	2003-02-06 15:19:26.000000000 -0800
@@ -953,7 +953,7 @@
 	}
 	spin_unlock(&tu->qlock);
 	if (_wake) {
-		kill_fasync(&ctl->fasync, SIGIO, POLL_IN);
+		kill_fasync(&tu->fasync, SIGIO, POLL_IN);
 		wake_up(&tu->qchange_sleep);
 	}
 }

-- Fernando




-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com

current CVS: compile error

[Fernando Lopez-Lezcano]

I'm getting this error while building current CVS (one FC3):

  CC [M] 
/usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/darla20.o
  CC [M] 
/usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/cs46xx/dsp_spos_scb_lib.o
In file included from
/usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/darla20.c:109:
/usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:
In function `load_firmware':
/usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio.h:424:
sorry, unimplemented: inlining failed in call to 'free_firmware':
function body not available
/usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:544: sorry, unimplemented: called from here
make[5]: ***
[/usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/darla20.o] Error
1
make[4]: *** [/usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio]
Error 2
make[4]: *** Waiting for unfinished jobs....


-- Fernando




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

RE: current CVS: compile error

[Giuliano Pochini]

On 07-Jan-2005 Fernando Lopez-Lezcano wrote:
> I'm getting this error while building current CVS (one FC3):
>
> /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:
> In function `load_firmware':
> /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio.h:424:
> sorry, unimplemented: inlining failed in call to 'free_firmware':
> function body not available
> /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:544: sorry, unimplemented: called from here


I'll check this ASAP. What gcc are you using ?



--
Giuliano.


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: current CVS: compile error

[Takashi Iwai]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

At 06 Jan 2005 18:16:11 -0800,
Fernando Lopez-Lezcano wrote:
> 
> I'm getting this error while building current CVS (one FC3):

Does the attached patch work?


Takashi

[-- Attachment #2: Type: text/plain, Size: 1433 bytes --]

Index: alsa-driver/pci/echoaudio/echoaudio.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/pci/echoaudio/echoaudio.c,v
retrieving revision 1.2
diff -u -r1.2 echoaudio.c
--- alsa-driver/pci/echoaudio/echoaudio.c	28 Dec 2004 19:20:01 -0000	1.2
+++ alsa-driver/pci/echoaudio/echoaudio.c	7 Jan 2005 10:52:23 -0000
@@ -42,7 +42,7 @@
 	return err;
 }
 
-static inline void free_firmware(const struct firmware *fw_entry)
+static void free_firmware(const struct firmware *fw_entry)
 {
 	release_firmware(fw_entry);
 	DE_ACT(("firmware released\n"));
Index: alsa-driver/pci/echoaudio/echoaudio.h
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/pci/echoaudio/echoaudio.h,v
retrieving revision 1.1
diff -u -r1.1 echoaudio.h
--- alsa-driver/pci/echoaudio/echoaudio.h	27 Dec 2004 15:51:18 -0000	1.1
+++ alsa-driver/pci/echoaudio/echoaudio.h	7 Jan 2005 10:52:27 -0000
@@ -421,7 +421,7 @@
 static int wait_handshake(echoaudio_t *chip);
 static int send_vector(echoaudio_t *chip, u32 command);
 static int get_firmware(const struct firmware **fw_entry, const struct firmware *frm, echoaudio_t *chip);
-static inline void free_firmware(const struct firmware *fw_entry);
+static void free_firmware(const struct firmware *fw_entry);
 
 #ifdef ECHOCARD_HAS_MIDI
 static int enable_midi_input(echoaudio_t *chip, char enable);

RE: current CVS: compile error

[Fernando Lopez-Lezcano]

On Fri, 2005-01-07 at 01:19, Giuliano Pochini wrote:
> On 07-Jan-2005 Fernando Lopez-Lezcano wrote:
> > I'm getting this error while building current CVS (one FC3):
> >
> > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:
> > In function `load_firmware':
> > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio.h:424:
> > sorry, unimplemented: inlining failed in call to 'free_firmware':
> > function body not available
> > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:544: sorry, unimplemented: called from here
> 
> I'll check this ASAP. What gcc are you using ?

Standard gcc in fc3, gcc3.4 I believe (I don't have access to that
machine right now). 

-- Fernando




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: current CVS: compile error

[Giuliano Pochini]

On 07 Jan 2005 17:39:33 -0800
Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> wrote:

> > > I'm getting this error while building current CVS (one FC3):
> > >
> > > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:
> > > In function `load_firmware':
> > > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio.h:424:
> > > sorry, unimplemented: inlining failed in call to 'free_firmware':
> > > function body not available
> > > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:544: sorry, unimplemented: called from here
> >
> > I'll check this ASAP. What gcc are you using ?
>
> Standard gcc in fc3, gcc3.4 I believe (I don't have access to that
> machine right now).

Some versions of GCC do not like inline functions to be defined after the
point they are used. Gcc 2.95 and gcc 3.4.1 compile it without errors, so
you probably have 3.3.x. Btw, the patch posted by tiwai should fix it.


--
Giuliano.


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: current CVS: compile error

[Fernando Lopez-Lezcano]

On Sun, 2005-01-09 at 09:04, Giuliano Pochini wrote:
> On 07 Jan 2005 17:39:33 -0800
> Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> wrote:
> 
> > > > I'm getting this error while building current CVS (one FC3):
> > > >
> > > > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:
> > > > In function `load_firmware':
> > > > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio.h:424:
> > > > sorry, unimplemented: inlining failed in call to 'free_firmware':
> > > > function body not available
> > > > /usr/src/rpm/BUILD/alsa-driver-1.0.8rc2/pci/echoaudio/echoaudio_dsp.c:544: sorry, unimplemented: called from here
> > >
> > > I'll check this ASAP. What gcc are you using ?
> >
> > Standard gcc in fc3, gcc3.4 I believe (I don't have access to that
> > machine right now).
> 
> Some versions of GCC do not like inline functions to be defined after the
> point they are used. Gcc 2.95 and gcc 3.4.1 compile it without errors, so
> you probably have 3.3.x. Btw, the patch posted by tiwai should fix it.

Thanks, I have not had time to try it out yet (will soon, I hope). It
fails on gcc 3.4.2. 

-- Fernando




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt