[PATCH] Fix revision display from cat /proc/asound/card0/ac97#0

[PATCH] Fix revision display from cat /proc/asound/card0/ac97#0

[James Courtier-Dutton]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

This patch fixes the display of revision number for ALC650 AC97 chip.
"alsamixer"
displayed the correct revision, but
"cat /proc/asound/card0/ac97#0"
did not.

Cheers
James

[-- Attachment #2: ac97_proc-rev-fix.diff --]
[-- Type: text/plain, Size: 929 bytes --]

--- ac97_proc.c.org	2003-10-03 16:07:16.578344016 +0100
+++ ac97_proc.c	2003-10-03 16:56:14.184759960 +0100
@@ -37,15 +37,12 @@
 static void snd_ac97_proc_read_main(ac97_t *ac97, snd_info_buffer_t * buffer, int subidx)
 {
 	char name[64];
-	unsigned int id;
 	unsigned short val, tmp, ext, mext;
 	static const char *spdif_slots[4] = { " SPDIF=3/4", " SPDIF=7/8", " SPDIF=6/9", " SPDIF=res" };
 	static const char *spdif_rates[4] = { " Rate=44.1kHz", " Rate=res", " Rate=48kHz", " Rate=32kHz" };
 	static const char *spdif_rates_cs4205[4] = { " Rate=48kHz", " Rate=44.1kHz", " Rate=res", " Rate=res" };
 
-	id = snd_ac97_read(ac97, AC97_VENDOR_ID1) << 16;
-	id |= snd_ac97_read(ac97, AC97_VENDOR_ID2);
-	snd_ac97_get_name(NULL, id, name, 0);
+	snd_ac97_get_name(NULL, ac97->id, name, 0);
 	snd_iprintf(buffer, "%d-%d/%d: %s\n\n", ac97->addr, ac97->num, subidx, name);
 	if ((ac97->scaps & AC97_SCAP_AUDIO) == 0)
 		goto __modem;

Re: [PATCH] Fix revision display from cat /proc/asound/card0/ac97#0

[Takashi Iwai]

At Fri, 03 Oct 2003 17:00:42 +0100,
James Courtier-Dutton wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> This patch fixes the display of revision number for ALC650 AC97 chip.
> "alsamixer"
> displayed the correct revision, but
> "cat /proc/asound/card0/ac97#0"
> did not.

thanks, now committed to cvs together with your patch for ALC650
spdif-out.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf