Re: [PATCH v2 net-next 10/14] selftests: xsk: add a hardware mode to xskxceiver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] selftests/xsk: hardware ring software state out of sync on reset failure
--

commit b6f9e6a7023dfe76a4790e608f82c3aef2c3cf4a
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
selftests: xsk: add a hardware mode to xskxceiver

This commit adds a hardware testing mode to the xskxceiver selftest, passing
physical interface parameters over UDP/IPv4. It also introduces an early 
return optimization in hw_ring_size_reset to skip restoring hardware rings
if they are already at their default sizes.

> diff --git a/tools/testing/selftests/net/lib/xsk/test_xsk.c b/tools/testing/selftests/net/lib/xsk/test_xsk.c
> index 8d30c39c94c84..542c0579062a4 100644
> --- a/tools/testing/selftests/net/lib/xsk/test_xsk.c
> +++ b/tools/testing/selftests/net/lib/xsk/test_xsk.c
[ ... ]
> @@ -218,6 +291,10 @@ static int set_ring_size(struct ifobject *ifobj)
>  
>  int hw_ring_size_reset(struct ifobject *ifobj)
>  {
> +	if (ifobj->ring.tx_pending == ifobj->set_ring.default_tx &&
> +	    ifobj->ring.rx_pending == ifobj->set_ring.default_rx)
> +		return 0;
> +
>  	ifobj->ring.tx_pending = ifobj->set_ring.default_tx;
>  	ifobj->ring.rx_pending = ifobj->set_ring.default_rx;
>  	return set_ring_size(ifobj);

[Severity: Medium]
Does this early-return optimization leave the software state out of sync if
the ioctl fails?

If set_ring_size() fails (for example, due to EBUSY), the underlying hardware
retains its previous, non-default ring size. However, because
ifobj->ring.tx_pending and ifobj->ring.rx_pending were updated optimistically
before the call, they are left permanently reflecting the default values.

With this newly added early return, subsequent attempts to call
hw_ring_size_reset() will read the corrupted software state and immediately
return 0 without attempting to retry the ioctl. Could this leave the network
interface with an incorrect ring size during test case cleanup?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008114909.734364-1-maciej.fijalkowski@intel.com?part=10