Re: [PATCH v2 net-next 13/14] selftests: drv-net: test AF_XDP zero-copy with an SKB peer

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: drv-net: xsk.py crashes due to missing test_xsk_case_defs.h dependency
--

commit e8144917db97e8dcd48aff778b6c6ea34e332b01
Author: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

selftests: drv-net: test AF_XDP zero-copy with an SKB peer

This commit introduces xsk.py to test hardware AF_XDP cases using a
device under test and a remote xskxceiver pair. It adds the script to the
drivers/net/hw selftests and utilizes Python networking helpers for remote
execution. The runner dynamically parses test cases from the C header
definitions in the net/lib subsystem.

> diff --git a/tools/testing/selftests/drivers/net/hw/Makefile b/tools/testing/selftests/drivers/net/hw/Makefile
> index 18ce235a77f84..02e48e74f6c6c 100644
> --- a/tools/testing/selftests/drivers/net/hw/Makefile
> +++ b/tools/testing/selftests/drivers/net/hw/Makefile
> @@ -52,6 +52,7 @@ TEST_PROGS = \
>  	uso.py \
>  	vlan.py \
>  	xdp_metadata.py \
> +	xsk.py \
>  	xsk_reconfig.py \
>  	#

[Severity: Low]
Does xsk.py rely on any external test files that need to be explicitly
copied during out-of-tree builds?

Because the required data file ../../../net/lib/xsk/test_xsk_case_defs.h
is missing from TEST_INCLUDES in this Makefile, it appears this causes a
regression where the file won't be copied during out-of-tree run_tests
for this subsystem.

> diff --git a/tools/testing/selftests/drivers/net/hw/xsk.py b/tools/testing/selftests/drivers/net/hw/xsk.py
> new file mode 100755
> index 0000000000000..a33d4af869c7a
> --- /dev/null
> +++ b/tools/testing/selftests/drivers/net/hw/xsk.py
[ ... ]
> +SKIP_CODE = 4
> +XSK_BIN = (Path(__file__).parent / "../../../net/lib/xskxceiver").resolve()
> +XSK_CASES = XSK_BIN.parent / "xsk/test_xsk_case_defs.h"
> +
> +
> +def _hardware_cases():
> +    defs = XSK_CASES.read_text()

[Severity: Low]
Could this cause a regression where it unconditionally throws a
FileNotFoundError and crashes the script if the file was not deployed?

When running an out-of-tree build where the header is omitted from
TEST_INCLUDES (or if xskxceiver is legitimately not built), this
read_text() call in _hardware_cases() will crash before the
XSK_BIN.exists() graceful skip check can execute.

Would it be safer to verify XSK_CASES exists before reading it, or handle
the exception gracefully?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008114909.734364-1-maciej.fijalkowski@intel.com?part=13