Re: [PATCH 3/3] Input: add Nsiway NS2009 resistive touchscreen driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] i2c: missing named initializer in i2c_device_id array
--

commit 22cbbc5b42325e09804bb86ec6c548c4fefefb81
Author: Miotsuki Mizuno <founder@crepuse.com>

Input: add Nsiway NS2009 resistive touchscreen driver

Add polling support for the Nsiway NS2009 I2C touchscreen controller using
the input polling API and managed input allocation. Read 12-bit X/Y ADC
values and report BTN_TOUCH from the raw Z1 contact threshold.

Link: https://lore.kernel.org/all/20170315155140.54518-4-icenowy@aosc.xyz/

> diff --git a/drivers/input/touchscreen/ns2009.c b/drivers/input/touchscreen/ns2009.c
> new file mode 100644
> index 0000000000000..d5c1f9f96bb6b
> --- /dev/null
> +++ b/drivers/input/touchscreen/ns2009.c

[ ... ]

> +static const struct i2c_device_id ns2009_id[] = {
> +	{ "ns2009" },

[Severity: Low]
Should this array element use a named initializer?

The I2C subsystem guidelines specify that initialized arrays of type
struct i2c_device_id must be declared const and use named initializers
(e.g., { .name = "ns2009" }).

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, ns2009_id);
> +
> +static const struct of_device_id ns2009_of_match[] = {
> +	{ .compatible = "nsiway,ns2009" },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009144729.85832-1-founder@crepuse.com?part=3