Re: [PATCH v2 3/3] Input: add Nsiway NS2009 resistive touchscreen driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] i2c: i2c_device_id array is missing named initializers
--

commit 0ef31ef1051f1f4d0d958b8c5e57e36de085c191
Author: Miotsuki Mizuno <founder@crepuse.com>
Subject: Input: add Nsiway NS2009 resistive touchscreen driver

This commit introduces a new polling driver for the Nsiway NS2009 I2C
touchscreen controller. It supports reading 12-bit X/Y ADC values and reports
touch events using the raw Z1 contact threshold.

Link: https://lore.kernel.org/all/20170315155140.54518-4-icenowy@aosc.xyz/

> diff --git a/drivers/input/touchscreen/ns2009.c b/drivers/input/touchscreen/ns2009.c
> new file mode 100644
> index 0000000000000..d5c1f9f96bb6b
> --- /dev/null
> +++ b/drivers/input/touchscreen/ns2009.c

[ ... ]

> +static int ns2009_probe(struct i2c_client *client)
> +{

[ ... ]

> +	error = input_register_device(input);
> +	if (error)
> +		return dev_err_probe(dev, error,
> +				     "failed to register input device\n");
> +
> +	return 0;
> +}
> +
> +static const struct i2c_device_id ns2009_id[] = {
> +	{ "ns2009" },

[Severity: Low]
This isn't a runtime bug, but I2C subsystem guidelines require initialized
arrays of type struct i2c_device_id to use named initializers. Should this
element be initialized as { .name = "ns2009" } instead of positionally?

> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, ns2009_id);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011054223.93396-1-founder@crepuse.com?part=3