Re: [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: gpio: undocumented compatible string 'onnn,pca9655' breaks schema validation
--

commit 668c971a564e2ffdacc4bbee425f902a28c78be0
Author: Igor Velkov <iav@iav.lv>

arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64

This commit adds the ON Semiconductor PCA9655E 16-bit GPIO expander at 0x20
on I2C2 for the Kobol Helios64 board.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index d146e5075b4f8..a860bd2b3afc0 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -453,6 +453,20 @@ &i2c2 {
>  	i2c-scl-falling-time-ns = <30>;
>  	status = "okay";
>  
> +	gpio@20 {
> +		compatible = "onnn,pca9655", "nxp,pca9555";

[Severity: Low]
Will this compatible string array in the gpio@20 node cause a dt-bindings
schema validation warning?

The "onnn,pca9655" string does not appear to be documented in the dt-bindings
for PCA95xx.

Additionally, schema files typically restrict "nxp,pca9555" to be a standalone
string via a single-item enum. Using an array of two strings could violate the
length and content restrictions when running make dtbs_check.

> +		reg = <0x20>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&exp16_int_l>;
> +		vcc-supply = <&vcc3v3_sys_s3>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-helios64-pca9655-v1-0-673ee4432650@iav.lv?part=2