All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Add the PCA9655E GPIO expander to Kobol Helios64
@ 2026-10-09 20:45 ` Igor Velkov via B4 Relay
  0 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov via B4 Relay @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

On Rosen's binding v2 Krzysztof quoted the "onnn,pca9655",
"nxp,pca9555" form [1]. This series documents that form and adds its
first user, the expander on Kobol Helios64. Patch 1 is for the GPIO
tree, patch 2 for the Rockchip tree; they only meet in dtbs_check.

6dfda7947653 ("ARM: dts: marvell: armada-388: use onnn,pca9655
compatible") in linux-next lists "onnn,pca9655" alone on Clearfog and
Helios4; with this binding they would need the fallback as well.

Tested on Helios64 (7.3-rc6 with this DTB): pca953x binds at 2-0020,
all 16 lines read as inputs, and the interrupt on GPIO0_B1 is
registered and stays quiet. Interrupt delivery is not tested: nothing
is connected to the P5 header.

[1] https://lore.kernel.org/r/20261009-venomous-carmine-locust-f788ca@quoll

---
Igor Velkov (2):
      dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
      arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64

 .../devicetree/bindings/gpio/gpio-pca95xx.yaml       |  3 +++
 .../boot/dts/rockchip/rk3399-kobol-helios64.dts      | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+)
---
base-commit: 36b190eca882ecd39b5354f7ee995f939dc6d885
change-id: 20261009-helios64-pca9655-39643c2acf4d

Best regards,
-- 
Igor Velkov <iav@iav.lv>



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 0/2] Add the PCA9655E GPIO expander to Kobol Helios64
@ 2026-10-09 20:45 ` Igor Velkov via B4 Relay
  0 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov via B4 Relay @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

On Rosen's binding v2 Krzysztof quoted the "onnn,pca9655",
"nxp,pca9555" form [1]. This series documents that form and adds its
first user, the expander on Kobol Helios64. Patch 1 is for the GPIO
tree, patch 2 for the Rockchip tree; they only meet in dtbs_check.

6dfda7947653 ("ARM: dts: marvell: armada-388: use onnn,pca9655
compatible") in linux-next lists "onnn,pca9655" alone on Clearfog and
Helios4; with this binding they would need the fallback as well.

Tested on Helios64 (7.3-rc6 with this DTB): pca953x binds at 2-0020,
all 16 lines read as inputs, and the interrupt on GPIO0_B1 is
registered and stays quiet. Interrupt delivery is not tested: nothing
is connected to the P5 header.

[1] https://lore.kernel.org/r/20261009-venomous-carmine-locust-f788ca@quoll

---
Igor Velkov (2):
      dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
      arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64

 .../devicetree/bindings/gpio/gpio-pca95xx.yaml       |  3 +++
 .../boot/dts/rockchip/rk3399-kobol-helios64.dts      | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+)
---
base-commit: 36b190eca882ecd39b5354f7ee995f939dc6d885
change-id: 20261009-helios64-pca9655-39643c2acf4d

Best regards,
-- 
Igor Velkov <iav@iav.lv>



^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 0/2] Add the PCA9655E GPIO expander to Kobol Helios64
@ 2026-10-09 20:45 ` Igor Velkov via B4 Relay
  0 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

On Rosen's binding v2 Krzysztof quoted the "onnn,pca9655",
"nxp,pca9555" form [1]. This series documents that form and adds its
first user, the expander on Kobol Helios64. Patch 1 is for the GPIO
tree, patch 2 for the Rockchip tree; they only meet in dtbs_check.

6dfda7947653 ("ARM: dts: marvell: armada-388: use onnn,pca9655
compatible") in linux-next lists "onnn,pca9655" alone on Clearfog and
Helios4; with this binding they would need the fallback as well.

Tested on Helios64 (7.3-rc6 with this DTB): pca953x binds at 2-0020,
all 16 lines read as inputs, and the interrupt on GPIO0_B1 is
registered and stays quiet. Interrupt delivery is not tested: nothing
is connected to the P5 header.

[1] https://lore.kernel.org/r/20261009-venomous-carmine-locust-f788ca@quoll

---
Igor Velkov (2):
      dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
      arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64

 .../devicetree/bindings/gpio/gpio-pca95xx.yaml       |  3 +++
 .../boot/dts/rockchip/rk3399-kobol-helios64.dts      | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+)
---
base-commit: 36b190eca882ecd39b5354f7ee995f939dc6d885
change-id: 20261009-helios64-pca9655-39643c2acf4d

Best regards,
-- 
Igor Velkov <iav@iav.lv>


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH 1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
  2026-10-09 20:45 ` Igor Velkov via B4 Relay
  (?)
@ 2026-10-09 20:45   ` Igor Velkov via B4 Relay
  -1 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov via B4 Relay @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

From: Igor Velkov <iav@iav.lv>

The ON Semiconductor PCA9655E is a 16-bit I2C GPIO expander that the
pca953x driver handles as a PCA9555: both entries of its OF match
table carry OF_953X(16, PCA_INT), and onnn,pca9655 has been there since
commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
pca9655"). Document it with nxp,pca9555 as the fallback, the form the
comments in armada-388-clearfog.dtsi and armada-388-helios4.dts ask
for. The I2C core tries OF matching first, so the fallback form
probes; tested on Helios64, the first user.

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index 4631388a7d91..d671aaf83bb7 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -25,6 +25,9 @@ properties:
       - items:
           - const: kinetic,kts1622
           - const: ti,tcal6416
+      - items:
+          - const: onnn,pca9655
+          - const: nxp,pca9555
       - items:
           - enum:
               - exar,xra1202

-- 
2.43.0



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
@ 2026-10-09 20:45   ` Igor Velkov via B4 Relay
  0 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov via B4 Relay @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

From: Igor Velkov <iav@iav.lv>

The ON Semiconductor PCA9655E is a 16-bit I2C GPIO expander that the
pca953x driver handles as a PCA9555: both entries of its OF match
table carry OF_953X(16, PCA_INT), and onnn,pca9655 has been there since
commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
pca9655"). Document it with nxp,pca9555 as the fallback, the form the
comments in armada-388-clearfog.dtsi and armada-388-helios4.dts ask
for. The I2C core tries OF matching first, so the fallback form
probes; tested on Helios64, the first user.

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index 4631388a7d91..d671aaf83bb7 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -25,6 +25,9 @@ properties:
       - items:
           - const: kinetic,kts1622
           - const: ti,tcal6416
+      - items:
+          - const: onnn,pca9655
+          - const: nxp,pca9555
       - items:
           - enum:
               - exar,xra1202

-- 
2.43.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
@ 2026-10-09 20:45   ` Igor Velkov via B4 Relay
  0 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

The ON Semiconductor PCA9655E is a 16-bit I2C GPIO expander that the
pca953x driver handles as a PCA9555: both entries of its OF match
table carry OF_953X(16, PCA_INT), and onnn,pca9655 has been there since
commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
pca9655"). Document it with nxp,pca9555 as the fallback, the form the
comments in armada-388-clearfog.dtsi and armada-388-helios4.dts ask
for. The I2C core tries OF matching first, so the fallback form
probes; tested on Helios64, the first user.

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
index 4631388a7d91..d671aaf83bb7 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
@@ -25,6 +25,9 @@ properties:
       - items:
           - const: kinetic,kts1622
           - const: ti,tcal6416
+      - items:
+          - const: onnn,pca9655
+          - const: nxp,pca9555
       - items:
           - enum:
               - exar,xra1202

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64
  2026-10-09 20:45 ` Igor Velkov via B4 Relay
  (?)
@ 2026-10-09 20:45   ` Igor Velkov via B4 Relay
  -1 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov via B4 Relay @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

From: Igor Velkov <iav@iav.lv>

Helios64 has an ON Semiconductor PCA9655E 16-bit GPIO expander at 0x20
on I2C2, powered from VCC3V3_SYS_S3, with its lines on the P5 GPIO
header. Its INT# output goes to GPIO0_B1 with an external pull-up (R59
to 1V8_S3), so the pin has no internal bias. Schematic, sheet 34:
https://wiki.kobol.io/helios64/files/schematics/Helios64_Schematics_Rev1.2.pdf

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 .../boot/dts/rockchip/rk3399-kobol-helios64.dts      | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index d146e5075b4f..a860bd2b3afc 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -453,6 +453,20 @@ &i2c2 {
 	i2c-scl-falling-time-ns = <30>;
 	status = "okay";
 
+	gpio@20 {
+		compatible = "onnn,pca9655", "nxp,pca9555";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&exp16_int_l>;
+		vcc-supply = <&vcc3v3_sys_s3>;
+	};
+
 	temp@4c {
 		compatible = "national,lm75";
 		reg = <0x4c>;
@@ -493,6 +507,12 @@ user1_btn: user1-btn {
 		};
 	};
 
+	expander {
+		exp16_int_l: exp16-int-l {
+			rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	gmac {
 		gphy_reset: gphy-reset {
 			rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_output_low>;

-- 
2.43.0



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64
@ 2026-10-09 20:45   ` Igor Velkov via B4 Relay
  0 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov via B4 Relay @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

From: Igor Velkov <iav@iav.lv>

Helios64 has an ON Semiconductor PCA9655E 16-bit GPIO expander at 0x20
on I2C2, powered from VCC3V3_SYS_S3, with its lines on the P5 GPIO
header. Its INT# output goes to GPIO0_B1 with an external pull-up (R59
to 1V8_S3), so the pin has no internal bias. Schematic, sheet 34:
https://wiki.kobol.io/helios64/files/schematics/Helios64_Schematics_Rev1.2.pdf

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 .../boot/dts/rockchip/rk3399-kobol-helios64.dts      | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index d146e5075b4f..a860bd2b3afc 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -453,6 +453,20 @@ &i2c2 {
 	i2c-scl-falling-time-ns = <30>;
 	status = "okay";
 
+	gpio@20 {
+		compatible = "onnn,pca9655", "nxp,pca9555";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&exp16_int_l>;
+		vcc-supply = <&vcc3v3_sys_s3>;
+	};
+
 	temp@4c {
 		compatible = "national,lm75";
 		reg = <0x4c>;
@@ -493,6 +507,12 @@ user1_btn: user1-btn {
 		};
 	};
 
+	expander {
+		exp16_int_l: exp16-int-l {
+			rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	gmac {
 		gphy_reset: gphy-reset {
 			rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_output_low>;

-- 
2.43.0



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64
@ 2026-10-09 20:45   ` Igor Velkov via B4 Relay
  0 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov @ 2026-10-09 20:45 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: Rosen Penev, Gregory Clement, Andrew Lunn, Sebastian Hesselbarth,
	linux-gpio, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Igor Velkov

Helios64 has an ON Semiconductor PCA9655E 16-bit GPIO expander at 0x20
on I2C2, powered from VCC3V3_SYS_S3, with its lines on the P5 GPIO
header. Its INT# output goes to GPIO0_B1 with an external pull-up (R59
to 1V8_S3), so the pin has no internal bias. Schematic, sheet 34:
https://wiki.kobol.io/helios64/files/schematics/Helios64_Schematics_Rev1.2.pdf

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 .../boot/dts/rockchip/rk3399-kobol-helios64.dts      | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index d146e5075b4f..a860bd2b3afc 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -453,6 +453,20 @@ &i2c2 {
 	i2c-scl-falling-time-ns = <30>;
 	status = "okay";
 
+	gpio@20 {
+		compatible = "onnn,pca9655", "nxp,pca9555";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&exp16_int_l>;
+		vcc-supply = <&vcc3v3_sys_s3>;
+	};
+
 	temp@4c {
 		compatible = "national,lm75";
 		reg = <0x4c>;
@@ -493,6 +507,12 @@ user1_btn: user1-btn {
 		};
 	};
 
+	expander {
+		exp16_int_l: exp16-int-l {
+			rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	gmac {
 		gphy_reset: gphy-reset {
 			rockchip,pins = <3 RK_PB7 RK_FUNC_GPIO &pcfg_output_low>;

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64
  2026-10-09 20:45   ` Igor Velkov via B4 Relay
  (?)
  (?)
@ 2026-10-09 20:52   ` sashiko-bot
  2026-10-09 21:00     ` Igor Velkov
  -1 siblings, 1 reply; 15+ messages in thread
From: sashiko-bot @ 2026-10-09 20:52 UTC (permalink / raw)
  To: Igor Velkov; +Cc: linux-gpio, robh, conor+dt, devicetree

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: gpio: undocumented compatible string 'onnn,pca9655' breaks schema validation
--

commit 668c971a564e2ffdacc4bbee425f902a28c78be0
Author: Igor Velkov <iav@iav.lv>

arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64

This commit adds the ON Semiconductor PCA9655E 16-bit GPIO expander at 0x20
on I2C2 for the Kobol Helios64 board.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index d146e5075b4f8..a860bd2b3afc0 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -453,6 +453,20 @@ &i2c2 {
>  	i2c-scl-falling-time-ns = <30>;
>  	status = "okay";
>  
> +	gpio@20 {
> +		compatible = "onnn,pca9655", "nxp,pca9555";

[Severity: Low]
Will this compatible string array in the gpio@20 node cause a dt-bindings
schema validation warning?

The "onnn,pca9655" string does not appear to be documented in the dt-bindings
for PCA95xx.

Additionally, schema files typically restrict "nxp,pca9555" to be a standalone
string via a single-item enum. Using an array of two strings could violate the
length and content restrictions when running make dtbs_check.

> +		reg = <0x20>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <RK_PB1 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&exp16_int_l>;
> +		vcc-supply = <&vcc3v3_sys_s3>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009-helios64-pca9655-v1-0-673ee4432650@iav.lv?part=2

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64
  2026-10-09 20:52   ` sashiko-bot
@ 2026-10-09 21:00     ` Igor Velkov
  0 siblings, 0 replies; 15+ messages in thread
From: Igor Velkov @ 2026-10-09 21:00 UTC (permalink / raw)
  To: sashiko-reviews
  Cc: Heiko Stuebner, linux-gpio, robh, conor+dt, devicetree,
	Igor Velkov

Right, 2/2 depends on 1/2, which documents the pair; with both applied
dt-validate on the built DTB is clean. So 2/2 should go in after 1/2.

Igor

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
  2026-10-09 20:45   ` Igor Velkov via B4 Relay
@ 2026-10-12  9:07     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-12  9:07 UTC (permalink / raw)
  To: Igor Velkov
  Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Rosen Penev,
	Gregory Clement, Andrew Lunn, Sebastian Hesselbarth, linux-gpio,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel

On Fri, Oct 09, 2026 at 08:45:36PM +0000, Igor Velkov wrote:
> The ON Semiconductor PCA9655E is a 16-bit I2C GPIO expander that the
> pca953x driver handles as a PCA9555: both entries of its OF match
> table carry OF_953X(16, PCA_INT), and onnn,pca9655 has been there since
> commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
> pca9655"). Document it with nxp,pca9555 as the fallback, the form the
> comments in armada-388-clearfog.dtsi and armada-388-helios4.dts ask
> for. The I2C core tries OF matching first, so the fallback form
> probes; tested on Helios64, the first user.

Last sentence is redundant. Patches should not explain standard Linux
mechanics.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH 1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
@ 2026-10-12  9:07     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2026-10-12  9:07 UTC (permalink / raw)
  To: Igor Velkov
  Cc: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Rosen Penev,
	Gregory Clement, Andrew Lunn, Sebastian Hesselbarth, linux-gpio,
	devicetree, linux-arm-kernel, linux-rockchip, linux-kernel

On Fri, Oct 09, 2026 at 08:45:36PM +0000, Igor Velkov wrote:
> The ON Semiconductor PCA9655E is a 16-bit I2C GPIO expander that the
> pca953x driver handles as a PCA9555: both entries of its OF match
> table carry OF_953X(16, PCA_INT), and onnn,pca9655 has been there since
> commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
> pca9655"). Document it with nxp,pca9555 as the fallback, the form the
> comments in armada-388-clearfog.dtsi and armada-388-helios4.dts ask
> for. The I2C core tries OF matching first, so the fallback form
> probes; tested on Helios64, the first user.

Last sentence is redundant. Patches should not explain standard Linux
mechanics.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH 0/2] Add the PCA9655E GPIO expander to Kobol Helios64
  2026-10-09 20:45 ` Igor Velkov via B4 Relay
@ 2026-10-12 14:01   ` Bartosz Golaszewski
  -1 siblings, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2026-10-12 14:01 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Igor Velkov
  Cc: Bartosz Golaszewski, Rosen Penev, Gregory Clement, Andrew Lunn,
	Sebastian Hesselbarth, linux-gpio, devicetree, linux-arm-kernel,
	linux-rockchip, linux-kernel


On Fri, 09 Oct 2026 20:45:35 +0000, Igor Velkov wrote:
> On Rosen's binding v2 Krzysztof quoted the "onnn,pca9655",
> "nxp,pca9555" form [1]. This series documents that form and adds its
> first user, the expander on Kobol Helios64. Patch 1 is for the GPIO
> tree, patch 2 for the Rockchip tree; they only meet in dtbs_check.
> 
> 6dfda7947653 ("ARM: dts: marvell: armada-388: use onnn,pca9655
> compatible") in linux-next lists "onnn,pca9655" alone on Clearfog and
> Helios4; with this binding they would need the fallback as well.
> 
> [...]

I dropped the last sentence from the commit message and the Assisted-by tag
that's going away.

[1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
      https://git.kernel.org/brgl/c/356cab616b6f07a06c2d279fda8a9ec928fd5fff

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH 0/2] Add the PCA9655E GPIO expander to Kobol Helios64
@ 2026-10-12 14:01   ` Bartosz Golaszewski
  0 siblings, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2026-10-12 14:01 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Igor Velkov
  Cc: Bartosz Golaszewski, Rosen Penev, Gregory Clement, Andrew Lunn,
	Sebastian Hesselbarth, linux-gpio, devicetree, linux-arm-kernel,
	linux-rockchip, linux-kernel


On Fri, 09 Oct 2026 20:45:35 +0000, Igor Velkov wrote:
> On Rosen's binding v2 Krzysztof quoted the "onnn,pca9655",
> "nxp,pca9555" form [1]. This series documents that form and adds its
> first user, the expander on Kobol Helios64. Patch 1 is for the GPIO
> tree, patch 2 for the Rockchip tree; they only meet in dtbs_check.
> 
> 6dfda7947653 ("ARM: dts: marvell: armada-388: use onnn,pca9655
> compatible") in linux-next lists "onnn,pca9655" alone on Clearfog and
> Helios4; with this binding they would need the fallback as well.
> 
> [...]

I dropped the last sentence from the commit message and the Assisted-by tag
that's going away.

[1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback
      https://git.kernel.org/brgl/c/356cab616b6f07a06c2d279fda8a9ec928fd5fff

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2026-10-12 14:01 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-09 20:45 [PATCH 0/2] Add the PCA9655E GPIO expander to Kobol Helios64 Igor Velkov via B4 Relay
2026-10-09 20:45 ` Igor Velkov
2026-10-09 20:45 ` Igor Velkov via B4 Relay
2026-10-09 20:45 ` [PATCH 1/2] dt-bindings: gpio: pca95xx: add onnn,pca9655 with nxp,pca9555 fallback Igor Velkov via B4 Relay
2026-10-09 20:45   ` Igor Velkov
2026-10-09 20:45   ` Igor Velkov via B4 Relay
2026-10-12  9:07   ` Krzysztof Kozlowski
2026-10-12  9:07     ` Krzysztof Kozlowski
2026-10-09 20:45 ` [PATCH 2/2] arm64: dts: rockchip: Add the GPIO expander to Kobol Helios64 Igor Velkov via B4 Relay
2026-10-09 20:45   ` Igor Velkov
2026-10-09 20:45   ` Igor Velkov via B4 Relay
2026-10-09 20:52   ` sashiko-bot
2026-10-09 21:00     ` Igor Velkov
2026-10-12 14:01 ` (subset) [PATCH 0/2] Add the PCA9655E " Bartosz Golaszewski
2026-10-12 14:01   ` Bartosz Golaszewski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.