Re: [PATCH 17/24] dt-bindings: net: Add ZTE ZX279128S Ethernet switch

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: undefined phandles in example break dt_binding_check
--

commit efe0acccd5887c49f0011f1f35c4533d75acb64f
Author: Navid Ghahremani <ghahramani.navid@gmail.com>

dt-bindings: net: Add ZTE ZX279128S Ethernet switch

Describe the switch, receive interrupt and per-port PHY modes and MAC
addresses for the ZTE ZX279128S Ethernet switch.

> diff --git a/Documentation/devicetree/bindings/net/zte,zx279128s-gmac.yaml b/Documentation/devicetree/bindings/net/zte,zx279128s-gmac.yaml
> new file mode 100644
> index 0000000000000..56c81aa6e72ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/zte,zx279128s-gmac.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    ethernet@92000000 {
> +        compatible = "zte,zx279128s-gmac";
> +        reg = <0x92000000 0x400000>;
> +        interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
> +
> +        ethernet-ports {
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            port@0 {
> +                reg = <0>;
> +                label = "lan1";
> +                phy-handle = <&phy10>;
> +                phy-mode = "internal";
> +                nvmem-cells = <&macaddr 0>;

[Severity: Low]
Are the &phy10 and &macaddr phandles defined anywhere in this example snippet?

When dt_binding_check extracts and compiles this example, will dtc fail with
a reference to non-existent node or label error? Dummy nodes with the
corresponding labels might need to be added to the example.

> +                nvmem-cell-names = "mac-address";
> +            };
> +
> +            port@4 {
> +                reg = <4>;
> +                label = "wan";
> +                phy-handle = <&phy8>;

[Severity: Low]
Does the undefined &phy8 phandle here also cause a dtc compilation error
during dt_binding_check?

> +                phy-mode = "gmii";
> +                nvmem-cells = <&macaddr 1>;
> +                nvmem-cell-names = "mac-address";
> +            };
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010130024.177503-1-ghahramani.navid@gmail.com?part=17