Re: [PATCH v20 13/13] arm64: dts: qcom: kaanapali-mtp-camera-s5kjn5: Add DT overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: missing vddm-supply in s5kjn5 camera node
--

commit 0aa98e9fff565e6ca9fb3ef259881330ddffce3c
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

arm64: dts: qcom: kaanapali-mtp-camera-s5kjn5: Add DT overlay

This commit enables the S5KJN5 image sensor via CCI on the Kaanapali MTP board.
It creates a DTBO that configures the sensor on the CCI-0 interface.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-mtp-camera-s5kjn5.dtso b/arch/arm64/boot/dts/qcom/kaanapali-mtp-camera-s5kjn5.dtso
> new file mode 100644
> index 0000000000000..7b574e2ed3732
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kaanapali-mtp-camera-s5kjn5.dtso
[ ... ]
> +&cci0_i2c1 {
> +	camera@10 {
> +		compatible = "samsung,s5kjn5";
> +		reg = <0x10>;
> +
> +		reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&cam_mclk2_default &cam_reset2_default>;
> +
> +		clocks = <&cambistmclkcc CAM_BIST_MCLK_CC_MCLK2_CLK>;
> +		assigned-clocks = <&cambistmclkcc CAM_BIST_MCLK_CC_MCLK2_CLK>;
> +		assigned-clock-rates = <19200000>;
> +
> +		vddio-supply = <&vreg_l4n_1p8>;
> +		vddd-supply = <&vreg_l1m_1p0>;
> +		vdda-supply = <&vreg_l4m_2p2>;
> +		vddio1p2-supply = <&vreg_l2n_1p2>;
> +		afvdd-supply = <&vreg_l7m_2p8>;

[Severity: Medium]
Is the vddm-supply property missing for the camera@10 node?

The s5kjn5 driver unconditionally requests 6 regulators, including "vddm",
via devm_regulator_bulk_get(). Because the device tree overlay omits
vddm-supply, the regulator core will print a warning and return a dummy
regulator, or fail with -EPROBE_DEFER if full constraints aren't applied.

If the vddm pin is not physically tied to another active supply, the sensor's
MIPI PHY will not receive power, breaking camera streaming.

> +
> +		port {
> +			s5kjn5_out_ep: endpoint {
> +				data-lanes = <1 2 3 4>;
> +				link-frequencies = /bits/ 64 <1248000000>;
> +				remote-endpoint = <&csiphy2_in_ep>;
> +			};
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010-kaanapali-camss-v20-0-63e98ce9ac0c@oss.qualcomm.com?part=13