From: sashiko-bot@kernel.org
To: "Namhyung Kim" <namhyung@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 1/4] perf symbol: Fix symbol loading from libbfd
Date: Mon, 12 Oct 2026 05:37:09 +0000 [thread overview]
Message-ID: <sashiko-outbox-167677@kernel.org> (raw)
In-Reply-To: <20261012053013.14378-1-namhyung@kernel.org>
> The dso__load() should return a positive number (number of symbols
> loaded) when it succeded to load symbols. But dso__load_bfd_symbols()
> only returns 0 and it's hard to check if it actually loaded symbols or
> not. Let's return the value of dso__has_symbol() and check it in
> dso__load() so that it can return 1 for success.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/r/sashiko-outbox-162540@kernel.org
> Fixes: eac9a4342e5447cad ("perf symbols: Try reading the symbol table with libbfd")
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012053013.14378-1-namhyung@kernel.org?part=1
next prev parent reply other threads:[~2026-10-12 5:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 5:30 [PATCH v2 1/4] perf symbol: Fix symbol loading from libbfd Namhyung Kim
2026-10-12 5:30 ` [PATCH v2 2/4] perf symbol: Add missing symsrc__destroy() for libbfd Namhyung Kim
2026-10-12 5:36 ` sashiko-bot
2026-10-12 21:53 ` Ian Rogers
2026-10-12 5:30 ` [PATCH v2 3/4] perf symbol: Set dso symtab type " Namhyung Kim
2026-10-12 5:40 ` sashiko-bot
2026-10-12 19:36 ` Namhyung Kim
2026-10-12 5:30 ` [PATCH v2 4/4] perf test: Update PE file test for other locations Namhyung Kim
2026-10-12 5:38 ` sashiko-bot
2026-10-12 19:42 ` Namhyung Kim
2026-10-12 21:51 ` Ian Rogers
2026-10-12 23:06 ` Namhyung Kim
2026-10-12 23:11 ` Ian Rogers
2026-10-12 23:37 ` Namhyung Kim
2026-10-12 5:37 ` sashiko-bot [this message]
2026-10-12 21:52 ` [PATCH v2 1/4] perf symbol: Fix symbol loading from libbfd Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167677@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.