Re: [PATCH v2 3/4] perf symbol: Set dso symtab type for libbfd

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] perf symbol: incomplete dso state initialization for libbfd causing annotate/unwind failure
--

commit 5475c2801d673496a1fee31f44ca921eca39f20c
Author: Namhyung Kim <namhyung@kernel.org>

perf symbol: Set dso symtab type for libbfd

It missed to set the dso symtab type when the symbols are loaded by
libbfd.  When it happens both syms_ss and runtime_ss may not be set
and won't call dso__load_sym().

> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 4878d4292eb85..a90ce714b174b 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -1925,6 +1925,7 @@ int dso__load(struct dso *dso, struct map *map)
>  			nsinfo__mountns_enter(dso__nsinfo(dso), &nsc);
>  
>  		if (bfdrc > 0) {
> +			dso__set_symtab_type(dso, symtab_type);

[Severity: Medium]
When dso__load() takes this early exit to out_destroy, it bypasses the rest
of the loop which normally initializes symsrc_filename and binary_type:

		if (!syms_ss && symsrc__has_symtab(ss)) {
			syms_ss = ss;
			next_slot = true;
			if (!dso__symsrc_filename(dso))
				dso__set_symsrc_filename(dso, strdup(name));
		}
...
		if (next_slot) {
...
			if (dso__binary_type(dso) == DSO_BINARY_TYPE__NOT_FOUND || ... )
				dso__set_binary_type(dso, symtab_type);

Does skipping these initializations leave the DSO's binary_type as
DSO_BINARY_TYPE__NOT_FOUND?

If so, could this cause perf annotate to fail later on, since
symbol__disassemble() checks for this exact condition and returns an error?

tools/perf/util/disasm.c:symbol__disassemble()
...
	if (dso__binary_type(dso) == DSO_BINARY_TYPE__NOT_FOUND) {
		return SYMBOL_ANNOTATE_ERRNO__COULDNT_DETERMINE_FILE_TYPE;
	}
...

>  			ret = 1;
>  			goto out_destroy;
>  		}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012053013.14378-1-namhyung@kernel.org?part=3