* [PATCH] serial: ma35d1: Do not force-enable an unselected console
@ 2026-10-12 5:53 Karl Mehltretter
2026-10-12 6:02 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-10-12 5:53 UTC (permalink / raw)
To: Jacky Huang, Shan-Chun Hung, Greg Kroah-Hartman, Jiri Slaby
Cc: Karl Mehltretter, Ilpo Järvinen, linux-arm-kernel,
linux-serial, linux-kernel
When another console is selected and there is no matching ttyNVT console
argument, the core accepts the MA35D1 console without calling its setup
function because it has CON_ENABLED set before registration. Its index
remains -1 and printk repeatedly reports an invalid port, flooding the
console and preventing boot.
Let the console core enable it after successful setup.
Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
drivers/tty/serial/ma35d1_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
index 0809655f4395..3be30fb05513 100644
--- a/drivers/tty/serial/ma35d1_serial.c
+++ b/drivers/tty/serial/ma35d1_serial.c
@@ -639,7 +639,7 @@ static struct console ma35d1serial_console = {
.write = ma35d1serial_console_write,
.device = uart_console_device,
.setup = ma35d1serial_console_setup,
- .flags = CON_PRINTBUFFER | CON_ENABLED,
+ .flags = CON_PRINTBUFFER,
.index = -1,
.data = &ma35d1serial_reg,
};
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: ma35d1: Do not force-enable an unselected console
2026-10-12 5:53 [PATCH] serial: ma35d1: Do not force-enable an unselected console Karl Mehltretter
@ 2026-10-12 6:02 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-10-12 6:02 UTC (permalink / raw)
To: Karl Mehltretter; +Cc: linux-serial
> When another console is selected and there is no matching ttyNVT console
> argument, the core accepts the MA35D1 console without calling its setup
> function because it has CON_ENABLED set before registration. Its index
> remains -1 and printk repeatedly reports an invalid port, flooding the
> console and preventing boot.
>
> Let the console core enable it after successful setup.
>
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012055340.16719-1-kmehltretter@gmail.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-12 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-12 5:53 [PATCH] serial: ma35d1: Do not force-enable an unselected console Karl Mehltretter
2026-10-12 6:02 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.