Re: [PATCH v9 1/3] dt-bindings: clock: airoha: Document support for AN7583 clock

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing #reset-cells and #phy-cells in required properties for airoha,an7583-scu
--

commit 538a7c87406554f4bcd77061661b7f96dc72a786
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: clock: airoha: Document support for AN7583 clock

This commit documents support for the Airoha AN7583 clock, based on the
EN7523 schema. It adds the airoha,chip-scu phandle to make the separation
of SCU and chip SCU registers explicit, and introduces bindings for new
clock and reset lines.

> diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> index fc37786ac7ed8..8b94113d00ab7 100644
> --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
> +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml
[ ... ]
> @@ -57,12 +58,34 @@ properties:
>        available serdes port.
>      const: 1
>  
> +  airoha,chip-scu:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to the Chip SCU providing the registers required
> +      for configuring the PCIe related clocks and resets.
> +
>  required:
>    - compatible
>    - reg
>    - '#clock-cells'
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: airoha,an7583-scu
> +
> +    then:
> +      properties:
> +        reg:
> +          maxItems: 1
> +
> +      required:
> +        - airoha,chip-scu

[Severity: Medium]
Does this list of required properties for the airoha,an7583-scu variant need
to include '#reset-cells' and '#phy-cells'?

Since this variant functions as a reset provider and permits PHY serdes
selection, omitting these from the required properties in this conditional
block could allow incomplete device tree nodes to pass schema validation.

> +
> +    else:
> +      properties:
> +        airoha,chip-scu: false
> +
>    - if:
>        properties:
>          compatible:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012115954.92718-1-ansuelsmth@gmail.com?part=1