[PATCH v2 0/2] Add SPI display support for UNIHIKER M10 V1.2

[PATCH v2 0/2] Add SPI display support for UNIHIKER M10 V1.2

[Miotsuki Mizuno]

Add the panel compatible and enable the SPI2 display using the existing
panel-mipi-dbi driver. This series depends on the separate common I2C2
board preparation patch in this review package, but not on NS2009.

The external initialization firmware is available at:
https://github.com/mio-tsuki/panel-mipi-dbi-firmware/releases/tag/v1.0.0
Required filename: dfrobot,unihiker-m10-display.bin
SHA256: 50412ae6d29c5bbfb7fac585528a761fb249d7944011a1b19c5e0f80a0418e5f

Changes since v1:
- Normalize author/sender identity and preserve it in each patch body.
- Check every patch in both ordinary and strict modes with the binding
  present when checking the DTS compatible.

The binding and DTS diffs are unchanged. Prior physical display tests
passed RGB565 patterns, direction and partial/full updates. Register
readback showed a 100 MHz input with BAUDR=2 for 50 MHz transfers; no
oscilloscope measurement is claimed. Reset ACTIVE_HIGH was physically
verified. The nominal active area is represented as 43 x 58 mm.

Mizuno Miotsuki (2):
  dt-bindings: display: panel-mipi-dbi-spi: Add UNIHIKER M10 display
  arm64: dts: rockchip: Enable display on UNIHIKER M10 V1.2

 .../display/panel/panel-mipi-dbi-spi.yaml     |  1 +
 .../dts/rockchip/rk3308-unihiker-m10-v1.2.dts | 53 +++++++++++++++++++
 2 files changed, 54 insertions(+)


base-commit: d6c0b613da7796745d9ae71d0d0b87cb48ca25c6
-- 
2.56.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH v2 0/2] Add SPI display support for UNIHIKER M10 V1.2

[Miotsuki Mizuno]

Add the panel compatible and enable the SPI2 display using the existing
panel-mipi-dbi driver. This series depends on the separate common I2C2
board preparation patch in this review package, but not on NS2009.

The external initialization firmware is available at:
https://github.com/mio-tsuki/panel-mipi-dbi-firmware/releases/tag/v1.0.0
Required filename: dfrobot,unihiker-m10-display.bin
SHA256: 50412ae6d29c5bbfb7fac585528a761fb249d7944011a1b19c5e0f80a0418e5f

Changes since v1:
- Normalize author/sender identity and preserve it in each patch body.
- Check every patch in both ordinary and strict modes with the binding
  present when checking the DTS compatible.

The binding and DTS diffs are unchanged. Prior physical display tests
passed RGB565 patterns, direction and partial/full updates. Register
readback showed a 100 MHz input with BAUDR=2 for 50 MHz transfers; no
oscilloscope measurement is claimed. Reset ACTIVE_HIGH was physically
verified. The nominal active area is represented as 43 x 58 mm.

Mizuno Miotsuki (2):
  dt-bindings: display: panel-mipi-dbi-spi: Add UNIHIKER M10 display
  arm64: dts: rockchip: Enable display on UNIHIKER M10 V1.2

 .../display/panel/panel-mipi-dbi-spi.yaml     |  1 +
 .../dts/rockchip/rk3308-unihiker-m10-v1.2.dts | 53 +++++++++++++++++++
 2 files changed, 54 insertions(+)


base-commit: d6c0b613da7796745d9ae71d0d0b87cb48ca25c6
-- 
2.56.0

[PATCH v2 1/2] dt-bindings: display: panel-mipi-dbi-spi: Add UNIHIKER M10 display

[Miotsuki Mizuno]

From: Mizuno Miotsuki <founder@crepuse.com>

The DFRobot UNIHIKER M10 V1.2 has a 240x320 SPI display with an
ILI9341-compatible command interface. Its initialization sequence can
be supplied to the existing panel-mipi-dbi driver as firmware.

Add dfrobot,unihiker-m10-display as the panel-specific compatible,
with panel-mipi-dbi-spi as the fallback.

Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
---
 .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
index 6f0290c4e291..adef35f91670 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
@@ -72,6 +72,7 @@ properties:
   compatible:
     items:
       - enum:
+          - dfrobot,unihiker-m10-display
           - saef,sftc154b
           - sainsmart18
           - shineworld,lh133k
-- 
2.56.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH v2 1/2] dt-bindings: display: panel-mipi-dbi-spi: Add UNIHIKER M10 display

[Miotsuki Mizuno]

From: Mizuno Miotsuki <founder@crepuse.com>

The DFRobot UNIHIKER M10 V1.2 has a 240x320 SPI display with an
ILI9341-compatible command interface. Its initialization sequence can
be supplied to the existing panel-mipi-dbi driver as firmware.

Add dfrobot,unihiker-m10-display as the panel-specific compatible,
with panel-mipi-dbi-spi as the fallback.

Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
---
 .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
index 6f0290c4e291..adef35f91670 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
@@ -72,6 +72,7 @@ properties:
   compatible:
     items:
       - enum:
+          - dfrobot,unihiker-m10-display
           - saef,sftc154b
           - sainsmart18
           - shineworld,lh133k
-- 
2.56.0

Re: [PATCH v2 1/2] dt-bindings: display: panel-mipi-dbi-spi: Add UNIHIKER M10 display

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: display: panel-mipi-dbi-spi: Add UNIHIKER M10 display

[Conor Dooley]

[-- Attachment #1.1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH v2 2/2] arm64: dts: rockchip: Enable display on UNIHIKER M10 V1.2

[Miotsuki Mizuno]

From: Mizuno Miotsuki <founder@crepuse.com>

Enable the onboard 240x320 SPI display using panel-mipi-dbi. Add its
D/C and reset GPIOs, display timing, and PWM1 backlight, and enable
SPI2 with a maximum transfer frequency of 50 MHz.

Assign SPI2 a 100 MHz input clock from DPLL so that the controller's
even baud-rate divider can provide 50 MHz for pixel transfers.

Describe the 43.2 x 57.6 mm active area as 43 x 58 mm in the integer
millimetre properties. The panel uses RGB565 pixel data and requires the
external
initialization file dfrobot,unihiker-m10-display.bin. No DRM or SPI
controller driver changes are needed.

Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
---
 .../dts/rockchip/rk3308-unihiker-m10-v1.2.dts | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
index 0c03f118378a..4dc01ea73e44 100644
--- a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
@@ -22,6 +22,14 @@ chosen {
 		stdout-path = "serial0:1500000n8";
 	};
 
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm1 0 10000 0>;
+		brightness-levels = <0 16 32 48 64 80 96 112 128
+				     144 160 176 192 208 224 240 255>;
+		default-brightness-level = <12>;
+	};
+
 	keys {
 		compatible = "gpio-keys";
 
@@ -154,6 +162,13 @@ &pinctrl {
 	pinctrl-names = "default";
 	pinctrl-0 = <&rtc_32k>;
 
+	lcd {
+		lcd_control: lcd-control {
+			rockchip,pins = <1 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>,
+				       <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	sdmmc {
 		sd_vcc_en: sd-vcc-en {
 			rockchip,pins = <4 RK_PD6 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -183,6 +198,10 @@ &pwm0 {
 	status = "okay";
 };
 
+&pwm1 {
+	status = "okay";
+};
+
 &sdio {
 	#address-cells = <1>;
 	#size-cells = <0>;
@@ -216,6 +235,40 @@ &sdmmc {
 	status = "okay";
 };
 
+&spi2 {
+	assigned-clocks = <&cru SCLK_SPI2>;
+	assigned-clock-parents = <&cru PLL_DPLL>;
+	assigned-clock-rates = <100000000>;
+	status = "okay";
+
+	display@0 {
+		compatible = "dfrobot,unihiker-m10-display", "panel-mipi-dbi-spi";
+		reg = <0>;
+		spi-max-frequency = <50000000>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&lcd_control>;
+		dc-gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_HIGH>;
+		/* The DBI reset helper drives logical low, then high. */
+		reset-gpios = <&gpio1 RK_PB4 GPIO_ACTIVE_HIGH>;
+		backlight = <&backlight>;
+		format = "r5g6b5";
+		width-mm = <43>;
+		height-mm = <58>;
+
+		panel-timing {
+			clock-frequency = <0>;
+			hactive = <240>;
+			vactive = <320>;
+			hback-porch = <0>;
+			hfront-porch = <0>;
+			hsync-len = <0>;
+			vback-porch = <0>;
+			vfront-porch = <0>;
+			vsync-len = <0>;
+		};
+	};
+};
+
 &u2phy {
 	status = "okay";
 };
-- 
2.56.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH v2 2/2] arm64: dts: rockchip: Enable display on UNIHIKER M10 V1.2

[Miotsuki Mizuno]

From: Mizuno Miotsuki <founder@crepuse.com>

Enable the onboard 240x320 SPI display using panel-mipi-dbi. Add its
D/C and reset GPIOs, display timing, and PWM1 backlight, and enable
SPI2 with a maximum transfer frequency of 50 MHz.

Assign SPI2 a 100 MHz input clock from DPLL so that the controller's
even baud-rate divider can provide 50 MHz for pixel transfers.

Describe the 43.2 x 57.6 mm active area as 43 x 58 mm in the integer
millimetre properties. The panel uses RGB565 pixel data and requires the
external
initialization file dfrobot,unihiker-m10-display.bin. No DRM or SPI
controller driver changes are needed.

Signed-off-by: Mizuno Miotsuki <founder@crepuse.com>
---
 .../dts/rockchip/rk3308-unihiker-m10-v1.2.dts | 53 +++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
index 0c03f118378a..4dc01ea73e44 100644
--- a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
@@ -22,6 +22,14 @@ chosen {
 		stdout-path = "serial0:1500000n8";
 	};
 
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm1 0 10000 0>;
+		brightness-levels = <0 16 32 48 64 80 96 112 128
+				     144 160 176 192 208 224 240 255>;
+		default-brightness-level = <12>;
+	};
+
 	keys {
 		compatible = "gpio-keys";
 
@@ -154,6 +162,13 @@ &pinctrl {
 	pinctrl-names = "default";
 	pinctrl-0 = <&rtc_32k>;
 
+	lcd {
+		lcd_control: lcd-control {
+			rockchip,pins = <1 RK_PB4 RK_FUNC_GPIO &pcfg_pull_none>,
+				       <1 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
 	sdmmc {
 		sd_vcc_en: sd-vcc-en {
 			rockchip,pins = <4 RK_PD6 RK_FUNC_GPIO &pcfg_pull_none>;
@@ -183,6 +198,10 @@ &pwm0 {
 	status = "okay";
 };
 
+&pwm1 {
+	status = "okay";
+};
+
 &sdio {
 	#address-cells = <1>;
 	#size-cells = <0>;
@@ -216,6 +235,40 @@ &sdmmc {
 	status = "okay";
 };
 
+&spi2 {
+	assigned-clocks = <&cru SCLK_SPI2>;
+	assigned-clock-parents = <&cru PLL_DPLL>;
+	assigned-clock-rates = <100000000>;
+	status = "okay";
+
+	display@0 {
+		compatible = "dfrobot,unihiker-m10-display", "panel-mipi-dbi-spi";
+		reg = <0>;
+		spi-max-frequency = <50000000>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&lcd_control>;
+		dc-gpios = <&gpio1 RK_PB6 GPIO_ACTIVE_HIGH>;
+		/* The DBI reset helper drives logical low, then high. */
+		reset-gpios = <&gpio1 RK_PB4 GPIO_ACTIVE_HIGH>;
+		backlight = <&backlight>;
+		format = "r5g6b5";
+		width-mm = <43>;
+		height-mm = <58>;
+
+		panel-timing {
+			clock-frequency = <0>;
+			hactive = <240>;
+			vactive = <320>;
+			hback-porch = <0>;
+			hfront-porch = <0>;
+			hsync-len = <0>;
+			vback-porch = <0>;
+			vfront-porch = <0>;
+			vsync-len = <0>;
+		};
+	};
+};
+
 &u2phy {
 	status = "okay";
 };
-- 
2.56.0

Re: [PATCH v2 2/2] arm64: dts: rockchip: Enable display on UNIHIKER M10 V1.2

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: undocumented compatible string dfrobot,unihiker-m10-display
--

commit bb7cab2e48d73305c4348ab50dde38a500cc0a23
Author: Mizuno Miotsuki <founder@crepuse.com>

arm64: dts: rockchip: Enable display on UNIHIKER M10 V1.2

Enable the onboard 240x320 SPI display using panel-mipi-dbi. Add its
D/C and reset GPIOs, display timing, and PWM1 backlight, and enable
SPI2 with a maximum transfer frequency of 50 MHz.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
> index 270ea970c95a7..a3264ef23746e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3308-unihiker-m10-v1.2.dts
[ ... ]
> @@ -211,6 +230,40 @@ &sdmmc {
>  	status = "okay";
>  };
>  
> +&spi2 {
> +	assigned-clocks = <&cru SCLK_SPI2>;
> +	assigned-clock-parents = <&cru PLL_DPLL>;
> +	assigned-clock-rates = <100000000>;
> +	status = "okay";
> +
> +	display@0 {
> +		compatible = "dfrobot,unihiker-m10-display", "panel-mipi-dbi-spi";

[Severity: Low]
Does the dfrobot,unihiker-m10-display compatible string need to be added to
the corresponding YAML binding schema?

Since it is used here without being documented in the panel-mipi-dbi-spi
bindings, it might trigger validation warnings during make dtbs_check.

> +		reg = <0>;
> +		spi-max-frequency = <50000000>;
> +		pinctrl-names = "default";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012121718.53481-1-founder@crepuse.com?part=2